Re: [OpenJDK 2D-Dev] RFR 8144445: Maximum size checking in Marlin ArrayCache utility methods is not optimal

ArrayCache.java line 214 - was that supposed to be size or needSize on that line? Stroker.java line 1276 - "numCurves >= curveTypes.length" would also work...? In the test cases that expect an exception, if no exception is thrown then you pass the test. Is that right?

Re: [OpenJDK 2D-Dev] RFR 8144630: Use PrivilegedAction to create Thread in Marlin RendererStats

Looks good... ...jim On 12/3/15 1:37 PM, Laurent Bourgès wrote: https://bugs.openjdk.java.net/browse/JDK-8144630 Please review this simple webrev that fixes the Thread creation in RendererStats: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8144630.0/ Regards, Lau

Re: [OpenJDK 2D-Dev] RFR 8144654: Improve Marlin logging

Perhaps "isLoggingEnabled()"? This turns a bunch of constants from having compile-time values to run-time values so the javac compiler will no longer be able to compile the code out of the classfiles. On the other hand, the fields are still final so the Hotspot compiler should still be able t

Re: [OpenJDK 2D-Dev] RFR 8144718: Pisces / Marlin Strokers may generate invalid curves with huge coordinates and round joins

I'd make the test >= 0.5 since 0.5 generates a flat curve as well. And it couldn't hurt to mention that we are worried about round off error since someone coming along might wonder why we're worried that a cos() is > 1: // check round off errors producing cos(ext) > 1 and a NaN below // cos(e

Re: [OpenJDK 2D-Dev] RFR 8144446: Automate the Marlin crash test

Looks good. -phil. On 12/04/2015 02:55 PM, Jim Graham wrote: Looks good to me. Are jigsaw issues good Phil? ...jim On 12/3/15 12:58 PM, Laurent Bourgès wrote: Phil, If you were to run this on a jigsaw EA build it would fail due to accessing sun.java2d.pipe.Rendering

Re: [OpenJDK 2D-Dev] RFR: 8144245: [PIT] javax/imageio/plugins/shared/WriteAfterAbort.java

looks good. -phil. On 12/04/2015 02:27 PM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8144245 Patch: http://cr.openjdk.java.net/~bpb/8144245/webrev.00/ For the principal issue, the stream position was not being reset when the w

Re: [OpenJDK 2D-Dev] RFR 8144446: Automate the Marlin crash test

Looks good to me. Are jigsaw issues good Phil? ...jim On 12/3/15 12:58 PM, Laurent Bourgès wrote: Phil, If you were to run this on a jigsaw EA build it would fail due to accessing sun.java2d.pipe.RenderingEngine. I know this is "pre-existing" but jigsaw

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8140530, , Creating a VolatileImage with size 0, 0 results in no longer working g2d.drawStri

On 12/4/15 1:00 AM, Sergey Bylokhov wrote: Looks fine to me to. I guess that the native check still necessary in case we create a native surface as a cache for a BufferedImage. Or in case we want to relax the general API restriction later, it keeps us from ending up with a hard-to-diagnose bug

Re: [OpenJDK 2D-Dev] RFR 8144445: Maximum size checking in Marlin ArrayCache utility methods is not optimal

Looks good to me. -phil. On 12/03/2015 01:23 PM, Laurent Bourgès wrote: https://bugs.openjdk.java.net/browse/JDK-815 Please review that webrev that improves overflow checks in ArrayCache: http://cr.openjdk.java.net/~lbourges/marlin/marlin-815.0/

Re: [OpenJDK 2D-Dev] RFR 8144630: Use PrivilegedAction to create Thread in Marlin RendererStats

Looks good. BTW the JBS bug needs a "noreg-other" label (or similar) for all bugs that do not need a regression test. -phil. On 12/03/2015 01:37 PM, Laurent Bourgès wrote: https://bugs.openjdk.java.net/browse/JDK-8144630 Please review this simple webrev that fixes the Thread creation in Rende

Re: [OpenJDK 2D-Dev] RFR 8144654: Improve Marlin logging

139 public static boolean isEnableLogs() { 140 return getBoolean("sun.java2d.renderer.log", "false"); 141 } All of these begin with sun.java2d.renderer but they are all marlin specific. I guess it is OK though if we expect that ultimately marlin is the only renderer. "isEn

[OpenJDK 2D-Dev] RFR: 8144245: [PIT] javax/imageio/plugins/shared/WriteAfterAbort.java

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8144245 Patch: http://cr.openjdk.java.net/~bpb/8144245/webrev.00/ For the principal issue, the stream position was not being reset when the write was aborted to either the header position or to the position of t

[OpenJDK 2D-Dev] RFR: 8137106: EUDC (End User Defined Characters) are not displayed on Windows with Java 8u60+

https://bugs.openjdk.java.net/browse/JDK-8137106 http://cr.openjdk.java.net/~prr/8137106/index.html See the bug report for a long evaluation but here is the short version. In order to prevent recursive creation of the FontManager we need to have loading the construction of the TrueTypeFont repres

[OpenJDK 2D-Dev] RFR 8144718: Pisces / Marlin Strokers may generate invalid curves with huge coordinates and round joins

Hi, Please review this webrev fixing the Stroker bug in both Pisces & Marlin (same changes): bug: https://bugs.openjdk.java.net/browse/JDK-8144718 webrev: http://cr.openjdk.java.net/~lbourges/marlin/Stroker-8144718.0/ As this bug is very difficult to reproduce (artefacts), I just provide a simpl

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8144627: Problem list WriteAfterAbort.java

Indeed that is a good thing! :-) Brian On Dec 3, 2015, at 7:41 PM, Sergey Bylokhov wrote: > ps: I am glad that my test is written in a style that allowed to find a bug > in a new plug-in.

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8140530, , Creating a VolatileImage with size 0, 0 results in no longer working g2d.drawStri

Looks fine to me to. I guess that the native check still necessary in case we create a native surface as a cache for a BufferedImage. On 04.12.15 12:39, Jim Graham wrote: +1 ...jim On 12/3/15 10:17 PM, prasanta sadhukhan wrote: ok. Thanks Jim . Please review the modified webrev htt