I don't think it is impossible to fix in Java and it might even be
preferable
except that we perhaps need the low-level check anyway to be safe
(definitely the
case for the crash) and I was not sure we figured out the best place to
put in Java code
to minimise performance issues on normal cases
the unused import was removed (please see
http://cr.openjdk.java.net/~avstepan/8145776/webrev.02/test/javax/imageio/plugins/tiff/MultiPageTest/MultiPageTest.java.html)
> canWriteRasters should be checked also.
it returns false in the test. canInsertImage(index) should be checked
before writeIns
In such a case (canWriteSequence() && canWriteRasters()), I guess, we
return to the sole TIFF :)
On 1/12/2016 6:14 PM, Sergey Bylokhov wrote:
On 12/01/16 18:08, Alexander Stepanov wrote:
> applicable to all image types which canWriteSequence=true?
I'm not sure. E.g., for "gif" canWriteSequenc
> applicable to all image types which canWriteSequence=true?
I'm not sure. E.g., for "gif" canWriteSequence() returns "true", but
UnsupportedOperationException is thrown when calling writeInsert() (I
have to double-check).
(moreover, not sure if the gif created in such a way could be called
"
On 12/01/16 18:08, Alexander Stepanov wrote:
> applicable to all image types which canWriteSequence=true?
I'm not sure. E.g., for "gif" canWriteSequence() returns "true", but
UnsupportedOperationException is thrown when calling writeInsert() (I
have to double-check).
canWriteRasters should be
Hi, Alexander.
BitDepth.java the @summary should be updated. Why this test do not cover
the gif/bmp as well?
It is unclear why biRGBATypes are unused in the test.
On 12/01/16 17:40, Alexander Stepanov wrote:
Please ignore mistaken changes in ImageWriterCompressionTest
(re-uploading the webrev.
Please ignore mistaken changes in ImageWriterCompressionTest
(re-uploading the webrev...)
Thanks,
Alexander
On 1/12/2016 5:28 PM, Alexander Stepanov wrote:
Hello,
Some imageio plugins reg. tests should probably be updated to reflect
the fact that TIFF format is supported now.
Could you ple
Since "import javax.imageio.plugins.tiff.*" is unnecessary in the test,
i guess it is applicable to all image types which canWriteSequence=true?
On 11/01/16 14:49, Alexander Stepanov wrote:
Hello Semyon,
Thank you, that eliminates the question with the internal package.
Probably Brian meant th
Hello,
Some imageio plugins reg. tests should probably be updated to reflect
the fact that TIFF format is supported now.
Could you please let me know if the following changes are appropriate?
http://cr.openjdk.java.net/~avstepan/8146881/webrev.00/index.html
(bug: https://bugs.openjdk.java.net/
