[OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

2016-01-14 Thread Semyon Sadetsky
Hello, Please review the fix for jdk9. bug: https://bugs.openjdk.java.net/browse/JDK-8146042 webrev: http://cr.openjdk.java.net/~ssadetsky/8146042/webrev.00/ The root cause is incorrect coordinate rounding in D3D renderer. To fix the issue one of fudge factors was adjusted. Another issue

[OpenJDK 2D-Dev] Review request for JDK - 8146972 : ImageIO reader is not capable of reading JPEGs without JFIF header

2016-01-14 Thread Jayathirth D V
Hi, This is backport of fix from JDK 9 bug : https://bugs.openjdk.java.net/browse/JDK-8041501 to JDK 8u. Changes in JDK9 are already checked in. Please review the fix: Bug : https://bugs.openjdk.java.net/browse/JDK-8146972 Webrev :

Re: [OpenJDK 2D-Dev] Review request for 8144033 : [TEST_BUG] delays needed in RenderingToCachedGraphicsTest.java

2016-01-14 Thread Ajit Ghaisas
Hi, This test does not use D3D or OpenGL pipelines. D3D is specifically disabled and OpenGL is disabled by default on windows. This test uses GDI for drawing. In this case, the call " Toolkit.getDefaultToolkit().sync();" essentially translates to ::GdiFlush() only.

[OpenJDK 2D-Dev] [9] Review request for 8073400: Some Monospaced logical fonts have a different width

2016-01-14 Thread dmitry markov
Hello, Could you review the fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8073400 webrev: http://cr.openjdk.java.net/~dmarkov/8073400/jdk9/webrev.00/ Problem description: On Windows some characters (in particular, left and right double quotation marks) have width

Re: [OpenJDK 2D-Dev] RFR: 8145776: [TEST] add a test checking multipage tiff creation

2016-01-14 Thread Alexander Stepanov
Hello Sergey, In such a case I prefer to have a separate need-test bug to cover all the formats, please see https://bugs.openjdk.java.net/browse/JDK-8147082 This test was planned to cover tiff functionality (in the context of JEP 262). Thanks, Alexander On 1/13/2016 8:10 PM, Sergey

Re: [OpenJDK 2D-Dev] RFR: 8145776: [TEST] add a test checking multipage tiff creation

2016-01-14 Thread Alexander Stepanov
Thanks! On 1/14/2016 2:41 PM, Sergey Bylokhov wrote: On 14/01/16 13:41, Alexander Stepanov wrote: Hello Sergey, In such a case I prefer to have a separate need-test bug to cover all the formats, please see https://bugs.openjdk.java.net/browse/JDK-8147082 ok, thanks. looks fine. This test

Re: [OpenJDK 2D-Dev] RFR: 8145776: [TEST] add a test checking multipage tiff creation

2016-01-14 Thread Sergey Bylokhov
On 14/01/16 13:41, Alexander Stepanov wrote: Hello Sergey, In such a case I prefer to have a separate need-test bug to cover all the formats, please see https://bugs.openjdk.java.net/browse/JDK-8147082 ok, thanks. looks fine. This test was planned to cover tiff functionality (in the

Re: [OpenJDK 2D-Dev] Review request for 8144033 : [TEST_BUG] delays needed in RenderingToCachedGraphicsTest.java

2016-01-14 Thread Sergey Bylokhov
Notes which were discussed offline: - The test uses default pipeline(which can be d3d,ogl,x11,xrender) - The test also is executed with disabled d3d pipeline(in assumption that this pipeline is a default). - On each platform and pipeline the sync operation implements differently, discussion on

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

2016-01-14 Thread Sergey Bylokhov
Hi, Semyon. On what OS/VideCards did you test it? The test fails on my OSX using ogl pipeline. On 14/01/16 21:09, Semyon Sadetsky wrote: Hello, Please review the fix for jdk9. bug: https://bugs.openjdk.java.net/browse/JDK-8146042 webrev:

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

2016-01-14 Thread Phil Race
This fudge factor was last adjusted in https://bugs.openjdk.java.net/browse/JDK-6597822 way back before the D3D pipeline was released and the comments seem to indicate that there was a fair amount of testing on different hardware. I don't know why this seems to be in un-specified

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

2016-01-14 Thread Semyon Sadetsky
Hi Phil & Sergey, I have integrated Intel GPU i5 and cannot test other hardware. On Mac's retina display the screen capture doesn't return exact pixel to pixel image but the scaled one. So Mac platform should be excluded from testing: http://cr.openjdk.java.net/~ssadetsky/8146042/webrev.01/