Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

2016-01-19 Thread Alexander Stepanov
P.S. 'biGrayTypes' in BitDepth.java was commented as the color checks used in the test are improper in case of graycsale images. On 1/19/2016 7:17 PM, Alexander Stepanov wrote: Hello Sergey, please find the updated webrev: http://cr.openjdk.java.net/~avstepan/8146881/webrev.01/index.html Rega

Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

2016-01-19 Thread Alexander Stepanov
Hello Sergey, please find the updated webrev: http://cr.openjdk.java.net/~avstepan/8146881/webrev.01/index.html Regards, Alexander On 1/18/2016 5:12 PM, Sergey Bylokhov wrote: On 15/01/16 15:27, Alexander Stepanov wrote: Hello Sergey, > Why this test do not cover the gif/bmp as well? I can

Re: [OpenJDK 2D-Dev] RFR: 8147443: Use Common Cleaner in Marlin OffHeapArray

2016-01-19 Thread Mandy Chung
The change in modules.xml is fine. Mandy > On Jan 19, 2016, at 7:32 AM, Laurent Bourgès > wrote: > > Phil, > > I adopted your approach and please review the updated webrev: > http://cr.openjdk.java.net/~lbourges/marlin/marlin-Cleaner.2/ > > Changes: > - RendererContext: added cleanerObj used

Re: [OpenJDK 2D-Dev] RFR: 8147443: Use Common Cleaner in Marlin OffHeapArray

2016-01-19 Thread Laurent Bourgès
Phil, I adopted your approach and please review the updated webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-Cleaner.2/ Changes: - RendererContext: added cleanerObj used as Cleaner's parent reference + avoid updating the weak reference when using an hard reference - Renderer & MarlinCac

Re: [OpenJDK 2D-Dev] RFR: 8147443: Use Common Cleaner in Marlin OffHeapArray

2016-01-19 Thread Roger Riggs
Hi, This change looks ok to me (from the Cleaner perspective). (Phil, I'm assuming its just a typo that cleanerRef and cleanerObj should be the same.) Roger On 1/15/16 6:55 PM, Phil Race wrote: This looks fine to me. One comment that I am not sure applies here is that when using the equiva

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

2016-01-19 Thread Semyon Sadetsky
On 1/16/2016 12:10 AM, Sergey Bylokhov wrote: On 15/01/16 19:40, Semyon Sadetsky wrote: On 1/15/2016 6:46 PM, Sergey Bylokhov wrote: On 15/01/16 17:29, Semyon Sadetsky wrote: On 1/15/2016 4:30 PM, Sergey Bylokhov wrote: On 15/01/16 09:59, Semyon Sadetsky wrote: Hi Phil & Sergey, I have