Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8147077, , IllegalArgumentException thrown by api/java_awt/Component/FlipBufferStrategy/indexTGF_General

2016-01-22 Thread Jim Graham
That looks good. While we are at it, do any of the other platforms or pipelines need the same fix applied? ...jim On 1/22/2016 4:01 AM, prasanta sadhukhan wrote: Hi All, Please review a JCK regression fix for JDK-8140530

Re: [OpenJDK 2D-Dev] New warnings in layout code

2016-01-22 Thread Andrew Hughes
- Original Message - > Hi, snip... > > > Arguably the test could be removed but I would prefer to leave it in > > and change the code it so it is actually tested. > > > > -fno-strict-overflow is just too compiler-specific and too far removed > > from the code to be something I would want

[OpenJDK 2D-Dev] [9]: RFR JDK-8147077, , IllegalArgumentException thrown by api/java_awt/Component/FlipBufferStrategy/indexTGF_General

2016-01-22 Thread prasanta sadhukhan
Hi All, Please review a JCK regression fix for JDK-8140530 Bug: https://bugs.openjdk.java.net/browse/JDK-8147077 webrev: http://cr.openjdk.java.net/~psadhukhan/8147077/webrev.00/ JDK-8140530

Re: [OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] started to fail

2016-01-22 Thread Alexander Scherbatiy
I have created two separated issues on it: 8148045 Handle null resolution variant in SunGraphics2D https://bugs.openjdk.java.net/browse/JDK-8148045 8148046 Investigate the case where MRI.getResolutionVariant() returns MultiResolutionImage https://bugs.openjdk.java.net/browse/JDK-81

Re: [OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

2016-01-22 Thread Alexander Stepanov
Hello Sergey, Semyon, Thanks! Regards, Alexander On 1/22/2016 9:54 AM, Semyon Sadetsky wrote: Looks good to me. --Semyon On 1/19/2016 7:17 PM, Alexander Stepanov wrote: Hello Sergey, please find the updated webrev: http://cr.openjdk.java.net/~avstepan/8146881/webrev.01/index.html Regards,

Re: [OpenJDK 2D-Dev] Review Request for JDK - JDK-8022640 : ServiceRegistry (used by ImageIO) lack synchronization

2016-01-22 Thread prasanta sadhukhan
Looks good to me. Regards Prasanta On 1/21/2016 11:48 PM, Phil Race wrote: > public synchronized void finalize() { Whilst probably harmless, I can't think of a reason to make finalize() synchronized in this case. Normally it is called by the VM when the object is unreachable so there can't b