[OpenJDK 2D-Dev] RFR: 8148628: TIFFDirectory(getAsMetaData) created with one TIFFField having a IFD pointer tag throws ClassCastException & other naming differences (JEP 262)

2016-02-01 Thread Brian Burkhalter
Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8148628 Patch: http://cr.openjdk.java.net/~bpb/8148628/webrev.00/ Summary: 1) Needed to fix some problems in TIFFDirectory and TIFFFieldNode with respect to the fact that a TIFFDirectory contained in a

Re: [OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] started to fail

2016-02-01 Thread Jim Graham
I'm OK with the additional issues being addressed in follow-on fixes if that is what you are asking. The original fix in webrev.00 adds no additional harm and fixes a common case that is already breaking some code... ...jim On 2/1/16 1:04 AM, Jayathirth D V wrote:

Re: [OpenJDK 2D-Dev] Review request for 8069348 SunGraphics2D.copyArea() does not properly work for scaled graphics in D3D

2016-02-01 Thread Jim Graham
Hi Alexandr, This looks great. It's good to go, but you might want to fix one indenting issue before you push: X11SD and XRSD both had the same edit, but you made a different decision on whether to get rid of some extra parentheses or not and XRSD was left with the indentation off by 1.

Re: [OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] started to fail

2016-02-01 Thread Jayathirth D V
Hi Alex, Since two separate bugs are created for the suggestions given by Jim. And you are okay with the fix provided for the bug https://bugs.openjdk.java.net/browse/JDK-8147413 under webrev http://cr.openjdk.java.net/~jdv/8147413/webrev.00/ Can we push the fix into JDK9 after one more

Re: [OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] started to fail

2016-02-01 Thread Alexandr Scherbatiy
On 2/1/2016 1:04 AM, Jayathirth D V wrote: Hi Alex, Since two separate bugs are created for the suggestions given by Jim. And you are okay with the fix provided for the bug https://bugs.openjdk.java.net/browse/JDK-8147413 under webrev http://cr.openjdk.java.net/~jdv/8147413/webrev.00/ Can we

Re: [OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows L on Win 8.1 with HiDPI display

2016-02-01 Thread Alexandr Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8076545/webrev.04/ - both LOGPIXELSX and Y are used for the theme size scaling. - LOGPIXELSY is used for text metrics height rescaling Thanks, Alexandr. On 1/29/2016 1:16 PM, Jim Graham wrote: Hi Alexandr, Thanks

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8138749, , Revisited: PrinterJob.printDialog() does not support multi-mon, always displayed on primary

2016-02-01 Thread prasanta sadhukhan
Hi Phil, On 1/29/2016 3:04 PM, prasanta sadhukhan wrote: Hi Phil, On 1/28/2016 8:22 PM, Philip Race wrote: "in consistent" On 1/21/16, 11:20 PM, prasanta sadhukhan wrote: Hi Phil, I checked with NATIVE print dialog and with other app print dialog, they are positioning the dialog a little