Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

Hi Jay, The code changes look fine. There are a few issues with the use of VolatileImage in the test case, though. First, contentsLost is meant to be executed after an operation, not before. The class comments give an example of using it both during rendering to the VI and also during copy

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8066139, , Null return from PrintJob.getGraphics() running closed/java/awt/PrintJob/HighResTest/HighResTest.java

I don't think starting a new thread can be right. That would re-invoke printerJob.print() which even if you can reuse a PrinterJob (something that was never set out in spec.) you are surely getting a new spool job .. not a continuation. There a couple of other things I am not sure about either. I

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8034239, , PrintServiceLookup.lookupPrintServices() returns different amount of services in comparison with lpstat -v

Why do the copy ? Why not just add one line supportedDocFlavors = flavor -phil. On 03/07/2016 03:20 AM, prasanta sadhukhan wrote: Hi Phil, Please find the updated webrev: http://cr.openjdk.java.net/~psadhukhan/8034239/webrev.01/ I checked JDK-8040139 also passed with this modification. Reg

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8034239, , PrintServiceLookup.lookupPrintServices() returns different amount of services in comparison with lpstat -v

Hi Phil, Please find the updated webrev: http://cr.openjdk.java.net/~psadhukhan/8034239/webrev.01/ I checked JDK-8040139 also passed with this modification. Regards Prasanya On 3/5/2016 1:14 AM, Phil Race wrote: if the class is supposed to use the return value in this way what about these line