Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

Hi Jim, Thanks for the review. I have made changes in test case based on input provided. 1) Added contentsLost() after we drawImage() and getSnapshot() to verify the content and if it is lost loop again. 2) Removed recursive creation of VolatileImage based IMAGE_INCOMPATIBLE property. 3) Removed

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8034239, , PrintServiceLookup.lookupPrintServices() returns different amount of services in comparison with lpstat -v

Hi Phil, It's my mistake. There's no need to copy as we are not passing the supportedDocFlavors outside the class. I was influenced by the lines before this where copyFlavors was copied from supportedDocFlavors. Please find the updated webrev: http://cr.openjdk.java.net/~psadhukhan/8034239/web

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8066139, , Null return from PrintJob.getGraphics() running closed/java/awt/PrintJob/HighResTest/HighResTest.java

On 3/8/2016 2:17 AM, Phil Race wrote: I don't think starting a new thread can be right. That would re-invoke printerJob.print() which even if you can reuse a PrinterJob (something that was never set out in spec.) you are surely getting a new spool job .. not a continuation. There a couple of

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8034239, , PrintServiceLookup.lookupPrintServices() returns different amount of services in comparison with lpstat -v

Approved. -phil On 3/8/16, 2:26 AM, prasanta sadhukhan wrote: Hi Phil, It's my mistake. There's no need to copy as we are not passing the supportedDocFlavors outside the class. I was influenced by the lines before this where copyFlavors was copied from supportedDocFlavors. Please find the u

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8066139, , Null return from PrintJob.getGraphics() running closed/java/awt/PrintJob/HighResTest/HighResTest.java

> However, I am finding a strange issue with and without this fix too. The "Center" string is not printed Sounds completely unrelated to anything to do with the NPE bug. It is probably appropriate to file that as a separate bug. No big surprise that the behaviour is platform-specific as there i

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8034239, , PrintServiceLookup.lookupPrintServices() returns different amount of services in comparison with lpstat -v

Hi Prasanta, Looks good. Jennifer On 03/08/2016 02:26 AM, prasanta sadhukhan wrote: Hi Phil, It's my mistake. There's no need to copy as we are not passing the supportedDocFlavors outside the class. I was influenced by the lines before this where copyFlavors was copied from supportedDocFlavo

Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

Hi Jay, On 3/8/16 12:56 AM, Jayathirth D V wrote: Hi Jim, Thanks for the review. I have made changes in test case based on input provided. 1) Added contentsLost() after we drawImage() and getSnapshot() to verify the content and if it is lost loop again. Unfortunately, if contents are lost yo

Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

Hi Jim, I have made changes mentioned by you. Please find updated webrev: http://cr.openjdk.java.net/~jdv/8139183/webrev.05/ Thanks, Jay -Original Message- From: Jim Graham Sent: Wednesday, March 09, 2016 3:23 AM To: Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-