Hi Jim,
I have replaced wildcard imports with specific import and shared webrev to
Prasanta before pushing. Please find the webrev that is pushed for reference.
http://cr.openjdk.java.net/~jdv/8139183/webrev.07/
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Friday, March 11,
Actually, there is one functional difference between this implementation
and the Ductus pipeline...
The similar method in the Ductus pipeline is operating entirely on
device space coordinates after all transformation (which is why it can
have normalization built-in).
The method you modified
I can confirm that this is the same solution provided for the Ductus
code so it will bring us to par with the former rasterizer.
I would also check what happens when you try to render and
createStrokedPath() for a path that is so full of NaN values that it
never gets any segments out, and/or
Yes, that is the only issue I see now as well...
...jim
On 3/9/16 10:39 PM, prasanta sadhukhan wrote:
Looks good to me. Only thing that can be improved is instead of wildcard
imports, you can have specific imports in testcase.
Regards
Prasanta
On 3/10/2016 11:53 AM,
Hi,
Please review this bug fix for the Marlin renderer to properly ignore point
coordinates with NaN/Infinity values:
bug: https://bugs.openjdk.java.net/browse/JDK-8144938
webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8144938.0/
Changes:
- MarlinRenderingEngine.pathToLoop(): added
Hi, Ajit.
What about other cases in Raster.java, where the DataBuffer is passed as
a parameter? Probably we can simplify the code and find all such issues
if we changes the ByteInterleavedRaster/etc. For example:
ByteInterleavedRaster(SampleModel sampleModel,DataBuffer dataBuffer,...)
to
Hi Phil,
Bug: https://bugs.openjdk.java.net/browse/JDK-8151590
webrev: http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.00/
The issue is if application calls
JobAttributes.setDefaultSelection(JobAttributes.DefaultSelectionType.ALL);
along with
JobAttributes.setFromPage(2);
Hi Phil,
Please find the modified webrev
http://cr.openjdk.java.net/~psadhukhan/8066139/webrev.02/
I tested in Mac too but there it seems to be working (ie no NPE) without
and with this fix.
For issue seen on windows , I have raised a bug JDK-8151589
