Ajit,
There is also some odd indentation in ByteBandedRaster.java which is not
yours but
98 public ByteBandedRaster(SampleModel sampleModel,
99DataBufferByte dataBuffer,
100Point origin) {
This appears to be the result o
Hi Ajit,
Most of your if statements are spaced wrong. There should be a space
between "if" and the parentheses. I'll review more later, but I noticed
that issue in the first couple of files I looked at...
...jim
On 3/15/16 7:05 AM, Ajit Ghaisas wrote:
Hi,
Thanks Serge
+1 .. looks like a nice simplification.
Sorry it took me a couple of days to get back to this.
-phil.
On 03/18/2016 03:47 PM, Jim Graham wrote:
The edit looks fine to me... Phil?
...jim
On 3/18/16 9:52 AM, Laurent Bourgès wrote:
Jim,
Here is a final webrev (for archive):
http://cr
Thanks for the review Sergey.
Can I get +1 for this please?
-Jay
-Original Message-
From: Sergey Bylokhov
Sent: Tuesday, March 22, 2016 9:52 PM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In
ImageIO.read() an
On 22.03.16 19:31, Alexander Stepanov wrote:
Sorry, just a reminder.
Can you provide an information what was changed in this version?
Thanks,
Alexander
On 3/15/2016 7:12 PM, Alexander Stepanov wrote:
Please see the updated fix:
http://cr.openjdk.java.net/~avstepan/8149558/webrev.01/
Thank
Sorry, just a reminder.
Thanks,
Alexander
On 3/15/2016 7:12 PM, Alexander Stepanov wrote:
Please see the updated fix:
http://cr.openjdk.java.net/~avstepan/8149558/webrev.01/
Thanks,
Alexander
On 2/26/2016 6:54 PM, Alexander Stepanov wrote:
> Should we also test bmp and jpg?
couldn't use wri
This fix looks fine to me.
At least it made all code work in a similar way. But probably someone
will have other opinion?
On 22.03.16 12:34, Jayathirth D V wrote:
Hi Sergey,
I have unified changes related to ImageIO.read() and ImageIO.write().
In case of read() we will be returning null whe
Just curious, is the approach in SRCOVER_MASKFILL faster? I think yes,
but it adds and an additional branches which can affect performance. Did
you measure the difference?
On 22.03.16 14:35, Prahalad Kumar Narayanan wrote:
Observation from SRCOVER_MASKFILL
1. The mask fill reduces comput
Hello Everyone on Java2D Group
Good day to you.
This is a Follow-up to Review Request on the bug:
Bug : JDK-8015070 Anti-aliased Text on Translucent background
gets bright artifacts
Bug Link : https://bugs.openjdk.java.net/browse/JDK-8015070
First, Sincere thanks to Jim for h
Hi Phil,
I have modified the webrev as per your review comment regarding 0-based
page indices that osx native supports.
http://cr.openjdk.java.net/~psadhukhan/8042713/webrev.01/
I have tested with copies and pageranges set with my testcase and also
test/java/awt/print/PrinterJob/PageRanges.jav
Hi Sergey,
I have unified changes related to ImageIO.read() and ImageIO.write().
In case of read() we will be returning null when createImageInputStream()
returns null.
In case of write() we will be returning false when createImageOutputStream()
returns null.
Please find updated webrev for re
11 matches
Mail list logo
