Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased text on translucent backgrounds gets bright artifacts

Hi Prahalad, (On a side note - ouch! I came up with these macros in the first place, but 20 years later I'm now realizing just how hard they are to navigate and review. My apologies...) The macro you are still using to load the destination data is one that loads it to non-premultiplied

Re: [OpenJDK 2D-Dev] [9] Review-request for 6353518: Creation of a WritableRaster with a custom DataBuffer causes erroneous Exception

Whoops, I didn't see this before... Casts should be followed by a space as in: (Foo) bar // correct (Foo)bar // incorrect ...jim On 3/23/16 5:41 AM, Ajit Ghaisas wrote: Thanks Jim and Phil. Yes. It was a mistake to omit spaces in 'if' conditions. I have corrected

Re: [OpenJDK 2D-Dev] [9] Review-request for 6353518: Creation of a WritableRaster with a custom DataBuffer causes erroneous Exception

For the record, in many places in the 2D code we also adopt a slight extension of the indentation rules such that the below might be written as: public ByteBandedRaster(SampleModel sampleModel, DataBufferByte dataBuffer, Point origin)

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

I don't think this is ready and we need to discuss whether to rework it. In general I think I prefer IIO rather than null when we have a stream problem. For one thing you have this change :- 1522 * @returnfalse if no appropriate writer is found or 1523 * not able to create required

Re: [OpenJDK 2D-Dev] CFV: New 2D Group Member: Alexander Scherbatiy

Vote: yes On 3/17/2016 3:49 PM, Philip Race wrote: I hereby nominate Alexander Scherbatiy to membership in the 2D group. Alexander Scherbatiy is a current member of the Swing group and has contributed almost 200 changesets to OpenJDK :-

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8061258, , [macosx] PrinterJob's native Print Dialog does not reflect specified Copies or Page Ranges

On 3/23/16, 4:02 AM, prasanta sadhukhan wrote: Hi Phil, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8061258 Gosh, it appears I submitted that bug 18 months ago although I don't remember how I came across the problem. I need to understand the fix better and it

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-7107620, , Need to round in test java/awt/print/PageFormat/PageFormatFromAttributes.java

+1. I think one reviewer will suffice for this test fix. -phil. On 3/23/16, 12:26 AM, prasanta sadhukhan wrote: Hi Phil, Please review a simple fix for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-7107620 webrev: http://cr.openjdk.java.net/~psadhukhan/7107620/webrev.00/ It was seen

Re: [OpenJDK 2D-Dev] RFR 8144938: Handle properly coordinate overflow in Marlin Renderer

Phil & Jim, Thanks for the reviews ! I just pushed this patch after a complete synch (jigsaw): build & tested with MapBench. Laurent 2016-03-22 20:51 GMT+01:00 Phil Race : > +1 .. looks like a nice simplification. > > Sorry it took me a couple of days to get back to

Re: [OpenJDK 2D-Dev] Review Request for JDK-6185114: Undefined Exception in SampleModel, method createCompatibleSampleModel

+1 -phil. On 3/16/16, 4:45 AM, Ajit Ghaisas wrote: Hi, I have corrected the typo and modified the failure message string. Please review the updated webrev. http://cr.openjdk.java.net/~arapte/ajit/6185114/webrev.01/ Regards,

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8151590, , "ALL" radio button is not selected in printDialog when we call DefaultSelectionType.ALL in windows

Hi, There are three typos which you need to fix before you push No need for another webrev. 79 // seeting this dialog to native pritdialog 100 + " A print dialog wil lbe shown.\n " -phil. On 3/17/16, 1:35 AM, prasanta sadhukhan wrote: Hi Phil, Please find the

[OpenJDK 2D-Dev] RFR 8152183: [TEST] add test for TIFFField

Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8152183/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8152183 Just a single test added. Thanks, Alexander

Re: [OpenJDK 2D-Dev] [9] Review-request for 6353518: Creation of a WritableRaster with a custom DataBuffer causes erroneous Exception

Thanks Jim and Phil. Yes. It was a mistake to omit spaces in 'if' conditions. I have corrected the spacing issues for my changes now. I have corrected the indentation of the lines similar to those mentioned by Phil. I have also removed the redundant first condition check on line 890 in

[OpenJDK 2D-Dev] [9] RFR: JDK-8061258, , [macosx] PrinterJob's native Print Dialog does not reflect specified Copies or Page Ranges

Hi Phil, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8061258 webrev :http://cr.openjdk.java.net/~psadhukhan/8061258/webrev.00/ When user attempts to pre-populate the native dialog with copies and page ranges by calling PrintRequestAttributeSet aset = new

Re: [OpenJDK 2D-Dev] RFR 8149558: [TEST] add regression test for JDK-8150154

Hello, Sergey, > Should we also test bmp and jpg? covered as well > all of them have a white color and same size for the 2nd version the images used for the 1st and 2nd checks have different sizes and colors Thanks, Alexander On 3/22/2016 8:27 PM, Sergey Bylokhov wrote: On 22.03.16 19:31,

[OpenJDK 2D-Dev] [9] RFR: JDK-7107620, , Need to round in test java/awt/print/PageFormat/PageFormatFromAttributes.java

Hi Phil, Please review a simple fix for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-7107620 webrev: http://cr.openjdk.java.net/~psadhukhan/7107620/webrev.00/ It was seen width/height obtained by calculating via MediaSize/units is not same as obtained from Paper.getWIdth/getHeight(). It