Hi Phil,
Yes, the combination of this fix plus 8061258 works with both the
testcase I have along with the fix(es).
Jay, can you please review and give your +1 on this?
Regards
Prasanta
On 3/30/2016 12:13 AM, Phil Race wrote:
Like the related fix passing down page ranges to the dialog this loo
Hi Prasanta,
Changes are fine and test logic works fine.
In test case, There are some trailing white spaces, lines with more than 80
character, and typo’s in println please modify them before check-in.
Also bug mentions that that both no.of copies and from/to page are not getting
set. As w
Hi Prasanta,
Changes are working fine along with 8061258 changes and test case is working
fine.
In test case there are some trailing white spaces, unused imports and lines
extending 80 character length. Please modify them before pushing.
Thanks,
Jay
-Original Message-
From: prasanta sa
Hello Jim and Everyone on Java2D Group
Good day to you.
A quick follow-up to Review Request on bug:
Bug : JDK-8015070
Bug Link : https://bugs.openjdk.java.net/browse/JDK-8015070
Thank you Jim for the detailed feedback.
It takes a lot of time not only in performing the revi
Hi,
Thanks Sergey and Phil for answering some of Jim's concerns regarding this
fix.
I have answered rest of them below:
Raster.java, line 742: This branch of the switch statement instantiates a SWR
which doesn't have a specific buffer type. It could be replaced with just
"break;"
Hi Prahalad,
Benchmarks must run for a significant period of time to be valid.
Measuring with nanoTime() is fine, but the run times should exceed at
least a couple of seconds, not a few nanoseconds. You might want to use
Java2DBench instead (in src/demo/share/java2d in the java.desktop repo),
Actually, it was sufficient to make that apparent, but I again fell
under the spell of "all these methods are the same, so the same logic
should apply in each of them".
Apologies again for the non-sequitur. If it's a DBB, then the type must
be TYPE_BYTE...
...jim
On
Actually, there are other methods (well at least one that I spotted -
createPackedRaster) that get the data type from the DB itself, but also
switch on it. I suppose in that case the switch means we only have to
do a single instanceof check instead of 3 nested instanceof checks so it
is a perf
Hi Ajit,
On 3/30/2016 5:12 AM, Ajit Ghaisas wrote:
Raster.java, line 986: Something to file as a potential bug for future work
since the fix would have to be verified that it doesn't disrupt the other parts
of this method, but... The set of if statements in this method never checked
for a Ba
Hi Phil,
I found out we do not need to change minPage. Changing toPage before
frompage should be enough.
Please find the modified webrev:
http://cr.openjdk.java.net/~psadhukhan/6357905/webrev.01/
Regards
Prasanta
On 3/29/2016 6:45 AM, Philip Race wrote:
Please add an evaluation to the bug rep
10 matches
Mail list logo
