Re: [OpenJDK 2D-Dev] Review Request for JDK-8153363: Redundant check for number of components in PackedColorModel.equals() method

Hi Phil, I was analyzing HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-7107905"JDK-7107905 as part of it I was looking for any other subclass of ColorModel which doesn't have override equals() method. While doing this I found out that in PackedColorModel we are doing redundant check

[OpenJDK 2D-Dev] RFR: 8134986: Incorrect use of ConcurrentHashMap.contains in SunFontManager.java

https://bugs.openjdk.java.net/browse/JDK-8134986 When converted from a HashSet to a HashMap contains() should have changed to containsKey(). It does not lead to duplicate fonts because it is caught later on but it might lead to wasted work One line fix in line below diff --git

Re: [OpenJDK 2D-Dev] Review Request for JDK-8153363: Redundant check for number of components in PackedColorModel.equals() method

Looks good... ...jim On 4/4/16 8:35 AM, Jayathirth D V wrote: Hi, _Please review the following fix in JDK9:_ __ Bug : https://bugs.openjdk.java.net/browse/JDK-8153363 Webrev : http://cr.openjdk.java.net/~jdv/8153363/webrev.00/ Issue : We have redundant check for

[OpenJDK 2D-Dev] Result: New 2D Group Member: Alexander Scherbatiy

The vote for Alexander Scherbatiy [1] is now closed. Yes: 4 Veto: 0 Abstain: 0 According to the OpenJDK Bylaws definition of Lazy Consensus [2], this is sufficient to approve the nomination. -phil. [1] http://mail.openjdk.java.net/pipermail/2d-dev/2016-March/006513.html [2]

[OpenJDK 2D-Dev] Review Request for JDK-8153363: Redundant check for number of components in PackedColorModel.equals() method

Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8153363 Webrev : http://cr.openjdk.java.net/~jdv/8153363/webrev.00/ Issue : We have redundant check for equality of number of components in PackedColorModel. Solution : Number of

Re: [OpenJDK 2D-Dev] [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

Thanks to everyone for reviewing. I've pushed the fix today. Regards, Alexey On 17.03.2016 21:23, Phil Race wrote: +1 -phil. On 02/15/2016 01:02 AM, Erik Joelsson wrote: Looks good. /Erik On 2016-02-12 10:15, Seán Coffey wrote: Approved for jdk8u-dev once you have a peer code review.

[OpenJDK 2D-Dev] [9] RFR: JDK-6921664, , The amount of copies and the printer job name is not passed to the implementing

Hi All, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-6921664 webrev: http://cr.openjdk.java.net/~psadhukhan/6921664/webrev.00/ The issue was for a third party non-builtin print service, if the application sets the copies, jobname attribute these attributes are not

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

Hi Prasanta, Changes are fine and test case looks good. Please make proper indentation for jtreg comments before checkin. Thanks, Jay -Original Message- From: Phil Race Sent: Friday, April 01, 2016 10:47 PM To: prasanta sadhukhan Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9]: RFR