[OpenJDK 2D-Dev] [9] RFR JDK-6801613, , Cross-platform pageDialog and printDialog top margin entry broken

2016-04-05 Thread prasanta sadhukhan
Hi All, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-6801613 webrev: http://cr.openjdk.java.net/~psadhukhan/6801613/webrev.00/ The issue was the PrinterJob cross-platform "Page setup dialog" top margin entry is broken. If you enter a value in the top margin field

[OpenJDK 2D-Dev] [9] Review request for 8152309 Seamless way of using image filters with multi-resolution images

2016-04-05 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8152309 webrev: http://cr.openjdk.java.net/~alexsch/8152309/webrev.00 The purpose of the fix is to allow to apply an image filter for a multi-resolution image to get new multi-resolution image so the code be

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

2016-04-05 Thread Sergey Bylokhov
On 30.03.16 9:48, Jayathirth D V wrote: Thanks for pointing it out. It looks like redundant try-catch block. There is small code clean up is possible after your latest change: 1587 ImageOutputStream stream = null; 1588 stream = createImageOutputStream(output); I guess such code is redundant to

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

2016-04-05 Thread Jayathirth D V
Hi Sergey, It will be pushed after removing the redundant code. Please find the webrev: http://cr.openjdk.java.net/~jdv/8044289/webrev.07/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, April 05, 2016 8:05 PM To: Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject:

Re: [OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support

2016-04-05 Thread Alexander Scherbatiy
On 01/04/16 06:24, Jim Graham wrote: Hi Alexandr, Is there a bug filed to upgrade JLightweightFrame to allow non-integer (and X/Y) scales? We'd need this capability to implement "Swing embedded in FX" correctly on Win8.1+... I have created JDK-8153522 Update JLightweightFrame to allow no

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

2016-04-05 Thread Sergey Bylokhov
Looks fine, thanks. On 05.04.16 18:02, Jayathirth D V wrote: Hi Sergey, It will be pushed after removing the redundant code. Please find the webrev: http://cr.openjdk.java.net/~jdv/8044289/webrev.07/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, April 05, 2016 8:

Re: [OpenJDK 2D-Dev] RFR: 8146324: Add sun.font.FontUtilities.isComplexCharCode or related method to public API

2016-04-05 Thread Phil Race
I have an approved CCC sitting waiting for a 2nd reviewer on the code change -phil. On 03/25/2016 11:31 AM, Sergey Bylokhov wrote: Looks fine. On 25.03.16 20:56, Phil Race wrote: After a hallway conversation I have decided to change it to NPE. Not that I think it matters greatly either way si

Re: [OpenJDK 2D-Dev] RFR: 8146324: Add sun.font.FontUtilities.isComplexCharCode or related method to public API

2016-04-05 Thread Semyon Sadetsky
approved. --Semyon On 4/5/2016 9:45 PM, Phil Race wrote: I have an approved CCC sitting waiting for a 2nd reviewer on the code change -phil. On 03/25/2016 11:31 AM, Sergey Bylokhov wrote: Looks fine. On 25.03.16 20:56, Phil Race wrote: After a hallway conversation I have decided to change

Re: [OpenJDK 2D-Dev] CFV: New 2D Group Member: Alexander Scherbatiy

2016-04-05 Thread Jennifer Godinez
Vote: Yes - Jennifer On 3/17/2016 3:49 PM, Philip Race wrote: I hereby nominate Alexander Scherbatiy to membership in the 2D group. Alexander Scherbatiy is a current member of the Swing group and has contributed almost 200 changesets to OpenJDK :- http://hg.openjdk.java.net/jdk9/dev/jdk/log?re

Re: [OpenJDK 2D-Dev] RFR 8152183: [TEST] add test for TIFFField

2016-04-05 Thread Phil Race
45 private final static String FILENAME = "test.tiff"; 136 OutputStream s = new BufferedOutputStream(new FileOutputStream(FILENAME)); I did not think you could assume $CWD is writeable in jtreg tests. If I can be assured this is actually OK then I have no other issues. -phil.