Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict

Hi Jay, There was one thing I pointed out in the first review that got lost in the shuffle. When the validBits are not null you use isValid(i) to test the values, but that method does 3 things: - tests the index for validity, but we already know it is valid - tests validBits for null, but

Re: [OpenJDK 2D-Dev] [PATCH] JDK-8146035: Windows - With LCD antialiasing, some glyphs are not rendered correctly

Hello Dmitry, Thank you very much for your patch. The fix looks good to me. I will sponsor integrating the fix into the code base as soon as code review is complete. Thanks, Alexey On 07.04.2016 15:26, Dmitry Batrak wrote: Hello, I'd like to propose a fix for JDK-8146035. I am not a

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict

Sure Sergey after technical review is done I will raise CCC for the same. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Friday, April 08, 2016 12:42 AM To: Jim Graham; Jayathirth D V; Philip Race; Prasanta Sadhukhan Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev]

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict

Hi Jim, Thanks for the review. I have made all recommended changes and created new subtask for JDK-6588409(https://bugs.openjdk.java.net/browse/JDK-8153943 ). Please review updated webrev: http://cr.openjdk.java.net/~jdv/7107905/webrev.02/ Thanks, Jay -Original Message- From: Jim