Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6529030, , Java Printing: Print range > Selection gets enabled

2016-04-19 Thread Jennifer Godinez
Hi Prasanta, It looks to me that we missed to check (flags & PD_NOSELECTION) in setNativeAttributes that's why we are setting SunPageSelection attribute when we shouldn't. I think that is where we should put the fix. Jennifer On 04/15/2016 03:34 AM, prasanta sadhukhan wrote: Hi Phil, On

Re: [OpenJDK 2D-Dev] [9] Review request for 8152309 Seamless way of using image filters with multi-resolution images

2016-04-19 Thread Phil Race
I've gone up and down the API (and most of the implementation) ResolutionVariantItem is really only used in the public API in one place :- ImageProducer defines :- +default List getResolutionVariantItems() { +return Arrays.asList(new

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6197099 : PrinterJob.getUserName() throws a security exception when user.name permission is not given

2016-04-19 Thread Phil Race
+1 -phil On 04/19/2016 12:31 AM, prasanta sadhukhan wrote: Hi Phil, ccc request is approved. Can you please give +1 so that I can push this change? Regards Prasanta On 4/19/2016 12:59 PM, Jayathirth D V wrote: Looks good. -Original Message- From: prasanta sadhukhan Sent: Tuesday,

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6197099 : PrinterJob.getUserName() throws a security exception when user.name permission is not given

2016-04-19 Thread Jayathirth D V
Looks good. -Original Message- From: prasanta sadhukhan Sent: Tuesday, April 19, 2016 12:57 PM To: Jayathirth D V; Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6197099 : PrinterJob.getUserName() throws a security exception when user.name permission

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6197099 : PrinterJob.getUserName() throws a security exception when user.name permission is not given

2016-04-19 Thread prasanta sadhukhan
On 4/19/2016 12:42 PM, Jayathirth D V wrote: Hi Prasanta, In test case there is an indentation problem for multiline comments in jtreg. Also what I have observed is that in case of jtreg summary if we include "." after running jtreg in the report it will not show complete summary it will

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6197099 : PrinterJob.getUserName() throws a security exception when user.name permission is not given

2016-04-19 Thread Jayathirth D V
Hi Prasanta, In test case there is an indentation problem for multiline comments in jtreg. Also what I have observed is that in case of jtreg summary if we include "." after running jtreg in the report it will not show complete summary it will show only until the "." In your case it will show