Re: [OpenJDK 2D-Dev] [9] Review request for 8152309 Seamless way of using image filters with multi-resolution images

2016-04-20 Thread Alexander Scherbatiy
On 20/04/16 00:08, Phil Race wrote: I've gone up and down the API (and most of the implementation) ResolutionVariantItem is really only used in the public API in one place :- ImageProducer defines :- +default List> getResolutionVariantItems() { +return Arrays.asList(new Resolut

Re: [OpenJDK 2D-Dev] Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

2016-04-20 Thread Phil Race
On 04/20/2016 12:27 PM, Sergey Bylokhov wrote: 2d-dev added. In fact all these are 2D. No AWT warnings here. I am not sure but why "declaration in the code" is a bad thing and we should fix it? - DISABLED_WARNINGS_solstudio := E_DECLARATION_IN_CODE I cannot find the documentation in sola

Re: [OpenJDK 2D-Dev] Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

2016-04-20 Thread Sergey Bylokhov
2d-dev added. I am not sure but why "declaration in the code" is a bad thing and we should fix it? - DISABLED_WARNINGS_solstudio := E_DECLARATION_IN_CODE I cannot find the documentation in solaris studio for this warning. On 20.04.16 11:57, Ajit Ghaisas wrote: Hi, Bug : https://bugs.op

Re: [OpenJDK 2D-Dev] Review Request for JDK-8153943 : In java.awt.image package some of the classes are missing hashCode() or equals() method

2016-04-20 Thread Phil Race
Hi, You removed the following test in CCM.java : 2941 if (obj.getClass() != getClass()) { 2942 return false; 2943 } What this means is that before your change an instance of a subclass of CCM would never be equals() to any direct instantiatation of CCM but after yo

[OpenJDK 2D-Dev] [PATCH] JDK-8152680: Regression in GlyphVector.getGlyphCharIndex behaviour

2016-04-20 Thread Dmitry Batrak
Hello, I'd like to propose a patch for JDK-8152680 - an issue I've raised via bugreport.java.com earlier, hope someone can sponsor it. I have a Contributor status via agreement signed by Jetbrains. The issue is related to the extraction of glyph-to-character mapping from results of text layout, p

[OpenJDK 2D-Dev] Review Request for JDK-8153943 : In java.awt.image package some of the classes are missing hashCode() or equals() method

2016-04-20 Thread Jayathirth D V
Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8153943 This is subtask of https://bugs.openjdk.java.net/browse/JDK-6588409 Webrev : http://cr.openjdk.java.net/~jdv/8153943/webrev.00/ Issue : Some of the java.awt.image classes are

Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED

2016-04-20 Thread Jayathirth D V
Hi Jim, As discussed we will not add dithering error values to primary colors with color map which represents Primary colors approximately(+/-5 delta). I have made changes based on this suggestion and added new function to calculate whether color map represents primary colors approximately or no

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6529030, , Java Printing: Print range > Selection gets enabled

2016-04-20 Thread prasanta sadhukhan
Hi Jennifer, If I do not set SunPageSelection attribute in setNativeAttributes() like this + if ((flags & PD_NOSELECTION) != PD_NOSELECTION) { if ((flags & PD_PAGENUMS) != 0) { attributes.add(SunPageSelection.RANGE); } else if ((flags & PD_SELECTION) !=