Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6529030, , Java Printing: Print range > Selection gets enabled

2016-04-21 Thread prasanta sadhukhan
Hi Phil, As we discussed that java.awt.PrintJob should have selection radio button enabled as JobAttributes supports selection but java.awt.print.PrinterJob should NOT have selection radio button enabled as at API level, we do not support selection. So, as per suggestion by Jennifer I have mo

Re: [OpenJDK 2D-Dev] Review Request for JDK-8153943 : In java.awt.image package some of the classes are missing hashCode() or equals() method

2016-04-21 Thread Jayathirth D V
Hi Phil, Thanks for the review. I have updated the recommended changes also I made similar change in PixelInterleavedSampleModel.java because it is also a non-final & non-abstract class. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8153943/webrev.01/ Thanks,

Re: [OpenJDK 2D-Dev] Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

2016-04-21 Thread Ajit Ghaisas
>>On 04/20/2016 12:27 PM, Sergey Bylokhov wrote: >> 2d-dev added. >In fact all these are 2D. No AWT warnings here. >> >> I am not sure but why "declaration in the code" is a bad thing and we >> should fix it? >> - DISABLED_WARNINGS_solstudio := E_DECLARATION_IN_CODE >> >> I cannot find the docum

Re: [OpenJDK 2D-Dev] [9] request for review: 8078382: Wrong glyph is displayed for a derived font

2016-04-21 Thread Alexey Ivanov
Hi Phil, I ran a number of tests with different fonts: Windows GDI consistently selects Bold rather than Italic to produce the missing Bold Italic. So I suggest using Andrew's first patch: http://cr.openjdk.java.net/~bae/8078382/9/webrev.00/ The patch changes the order of font selection: bol

Re: [OpenJDK 2D-Dev] Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

2016-04-21 Thread Phil Race
> Another solution is to exclude this file from HEADLESS compilation. > I am not sure how to achieve it. Any suggestion? I suppose that is possible and I expect we can do that See in the make file, where I think you just need to add entries to LIBAWT_HEADLESS_EXCLUDES := medialib although