Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED

The code changes look good. One question on the test case, though - why is Color.WHITE commented out in the test case? Was it failing? ...jim On 4/29/16 4:45 AM, Jayathirth D V wrote: Hi, Thanks Phil & Jim for your inputs. I have made all recommended changes. Please

[OpenJDK 2D-Dev] RFR: 8149816: TIFFField#getValueAsString result is unexpected for RATIONAL and SRATIONAL types (when modulo is 0)

Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8149816 Patch: http://cr.openjdk.java.net/~bpb/8149816/webrev.00/ Summary: 1) Verified that the extant behavior is consistent with both the tiffdump and tiffinfo tools from the standard libtiff library. 2)

[OpenJDK 2D-Dev] RFR: 8155682: Get rid of legacy Windows Flags for DX

Bug : https://bugs.openjdk.java.net/browse/JDK-8155682 Webrev: http://cr.openjdk.java.net/~prr/8155682/ None of these flags have been referenced since (I think) the current D3D pipeline was integrated in 6u10/jdk7. JPRT built successfully. I was a little conservative in that

Re: [OpenJDK 2D-Dev] RFR: 8149810: TIFFField#getAsLong throws ClassCastException when data is type TIFFTag.TIFF_DOUBLE or TIFFTag.FLOAT

+1 -phil. On 04/29/2016 07:38 AM, Brian Burkhalter wrote: Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8149810 Patch: http://cr.openjdk.java.net/~bpb/8149810/webrev.00/ Summary: 1) Fix the code which caused the exception. 2) Update the specification of

Re: [OpenJDK 2D-Dev] RFR: 8151323: GeoTIFFTagSet#"ModelTiePointTag" name case does not match GeoTIFF specification

+1 -phil On 04/29/2016 09:45 AM, Brian Burkhalter wrote: Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8151323 Patch: http://cr.openjdk.java.net/~bpb/8151323/webrev.00/ Summary: s/ModelTiePointTag/ModelTiepointTag/ Thanks, Brian

Re: [OpenJDK 2D-Dev] RFR: 8149560: TIFFField#createFromMetadataNode throws a NullPointerException when the node is set with "tagNumber" attribute

+1 -phil. On 04/29/2016 10:50 AM, Brian Burkhalter wrote: Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8149560 Patch: http://cr.openjdk.java.net/~bpb/8149560/webrev.00/ Summary: 1) Change the specification of createFromMetadataNode() to change the tag

[OpenJDK 2D-Dev] RFR: 8149560: TIFFField#createFromMetadataNode throws a NullPointerException when the node is set with "tagNumber" attribute

Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8149560 Patch: http://cr.openjdk.java.net/~bpb/8149560/webrev.00/ Summary: 1) Change the specification of createFromMetadataNode() to change the tag number attribute name from “tagNumber” to “number” in accord

Re: [OpenJDK 2D-Dev] [PATCH] JDK-8146035: Windows - With LCD antialiasing, some glyphs are not rendered correctly

for the reference: the fix was committed to JDK8 and JDK9 Thank you Dmitry for your contribution! alexp On 4/14/2016 12:00, Alexey Ivanov wrote: Hi Phil, Thank you very much for your reviewing the code and approving the fix. I have uploaded the webrev to OpenJDK:

[OpenJDK 2D-Dev] RFR: 8151323: GeoTIFFTagSet#"ModelTiePointTag" name case does not match GeoTIFF specification

Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8151323 Patch: http://cr.openjdk.java.net/~bpb/8151323/webrev.00/ Summary: s/ModelTiePointTag/ModelTiepointTag/ Thanks, Brian

Re: [OpenJDK 2D-Dev] [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

> On 29 Apr 2016, at 18:19, Sergey Bylokhov wrote: > > On 29.04.16 18:01, Anton Tarasov wrote: >> [CC’ing to 2d-dev to discuss the issue] >> >>> On 29 Apr 2016, at 16:14, Sergey Bylokhov >>> wrote: >>> >>> On 29.04.16 15:53, Anton

Re: [OpenJDK 2D-Dev] [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

On 29.04.16 18:01, Anton Tarasov wrote: [CC’ing to 2d-dev to discuss the issue] On 29 Apr 2016, at 16:14, Sergey Bylokhov wrote: On 29.04.16 15:53, Anton Tarasov wrote: It seems so. But that might be not that critical, because it doesn’t hold (it won’t) any UI

Re: [OpenJDK 2D-Dev] [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

[CC’ing to 2d-dev to discuss the issue] > On 29 Apr 2016, at 16:14, Sergey Bylokhov wrote: > > On 29.04.16 15:53, Anton Tarasov wrote: >> It seems so. But that might be not that critical, because it doesn’t hold >> (it won’t) any UI controls and all the UI tree.

[OpenJDK 2D-Dev] RFR: 8149810: TIFFField#getAsLong throws ClassCastException when data is type TIFFTag.TIFF_DOUBLE or TIFFTag.FLOAT

Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8149810 Patch: http://cr.openjdk.java.net/~bpb/8149810/webrev.00/ Summary: 1) Fix the code which caused the exception. 2) Update the specification of getAsLong() to be similar to that of getAsInt(), i.e.,

Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED

Hi, Thanks Phil & Jim for your inputs. I have made all recommended changes. Please find updated webrev for review : http://cr.openjdk.java.net/~jdv/7116979/webrev.02/ Thanks, Jay -Original Message- From: Phil Race Sent: Tuesday, April 26, 2016 11:56 PM To: Jim Graham Cc: Jayathirth D