Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED

2016-05-02 Thread Jayathirth D V
Hi Jim, Thanks for your valuable review. I verified what you have mentioned and we are doing the same while mapping colormap to InverseLUT. I also tried populating InverseLUT serially from 0 to 255 index and with this change for white color also test is passing because we are selecting 215 index

Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased text on translucent backgrounds gets bright artifacts

2016-05-02 Thread Prahalad Kumar Narayanan
Dear Jim & Everyone on Java2D Community First, thanks to Jim for every word in the feedback. Java is used by millions of devices and users. We cannot compromise on quality. It 's through these reviews and iterations that we ensure a consistent solution gets checked in. I 've incorporated the s

Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased text on translucent backgrounds gets bright artifacts

2016-05-02 Thread Jim Graham
Thanks Prahalad, Looks great - +1 ...jim On 5/2/2016 8:29 AM, Prahalad Kumar Narayanan wrote: Dear Jim & Everyone on Java2D Community First, thanks to Jim for every word in the feedback. Java is used by millions of devices and users. We cannot compromise on quality. I

[OpenJDK 2D-Dev] [9] Review Request: 8028486 java/awt/Window/WindowsLeak/WindowsLeak.java fails

2016-05-02 Thread Sergey Bylokhov
Hello, Please review the fix for jdk9. Bug evaluation was done by Anton: http://mail.openjdk.java.net/pipermail/awt-dev/2016-April/011177.html This is a cross-platform bug it affects d3d/ogl pipelines. The problem is that BufferedContex cached information to skip some native reconfigurations.

Re: [OpenJDK 2D-Dev] [9] Review Request: 8028486 java/awt/Window/WindowsLeak/WindowsLeak.java fails

2016-05-02 Thread Phil Race
Just to make sure I understand this right, even if an application disposes of all Frames, we still somehow hold on to one Frame ? And it was the most recent one used by "validatedSrcData" due to some long reference chain ? WeakReferences are cleared quite aggressively so if an application loops

Re: [OpenJDK 2D-Dev] [9] Review Request: 8028486 java/awt/Window/WindowsLeak/WindowsLeak.java fails

2016-05-02 Thread Sergey Bylokhov
On 02.05.16 23:52, Phil Race wrote: Just to make sure I understand this right, even if an application disposes of all Frames, we still somehow hold on to one Frame ? And it was the most recent one used by "validatedSrcData" due to some long reference chain ? correct. https://bugs.openjdk.java.

Re: [OpenJDK 2D-Dev] [9] Review Request: 8028486 java/awt/Window/WindowsLeak/WindowsLeak.java fails

2016-05-02 Thread Phil Race
On 05/02/2016 02:08 PM, Sergey Bylokhov wrote: On 02.05.16 23:52, Phil Race wrote: Just to make sure I understand this right, even if an application disposes of all Frames, we still somehow hold on to one Frame ? And it was the most recent one used by "validatedSrcData" due to some long referen

Re: [OpenJDK 2D-Dev] [9] Review Request: 8028486 java/awt/Window/WindowsLeak/WindowsLeak.java fails

2016-05-02 Thread Sergey Bylokhov
On 03.05.16 0:07, Phil Race wrote: And this is fine because we use only identity checks inside the validate method. If the java object was deleted we should update the native state anyway. Not sure how to read that. Do you mean there is always some amount of work to do anyway ? An example: if

Re: [OpenJDK 2D-Dev] [9] Review Request: 8028486 java/awt/Window/WindowsLeak/WindowsLeak.java fails

2016-05-02 Thread Philip Race
On 5/2/16, 2:28 PM, Sergey Bylokhov wrote: On 03.05.16 0:07, Phil Race wrote: And this is fine because we use only identity checks inside the validate method. If the java object was deleted we should update the native state anyway. Not sure how to read that. Do you mean there is always some