Re: [OpenJDK 2D-Dev] [9] Review Request: Cleanup of sun.java2d.pipe.Region

2016-05-12 Thread Sergey Bylokhov
On 13.05.16 0:45, Jim Graham wrote: Looks good +1. Is there a bug filed for this? Filed: https://bugs.openjdk.java.net/browse/JDK-8156894 ...jim On 5/12/16 1:50 PM, Sergey Bylokhov wrote: This looks great! I guess the final was removed from the getters because the class is no

Re: [OpenJDK 2D-Dev] [9] Review Request: Cleanup of sun.java2d.pipe.Region

2016-05-12 Thread Jim Graham
Looks good +1. Is there a bug filed for this? ...jim On 5/12/16 1:50 PM, Sergey Bylokhov wrote: This looks great! I guess the final was removed from the getters because the class is now final, though it probably doesn't hurt anything to leave them final. In any case,

Re: [OpenJDK 2D-Dev] [9] Review Request: Cleanup of sun.java2d.pipe.Region

2016-05-12 Thread Sergey Bylokhov
This looks great! I guess the final was removed from the getters because the class is now final, though it probably doesn't hurt anything to leave them final. In any case, you only removed it from 3 of them, so it is unbalanced now. Ouch, it was the last minute change. Yes, the final keywords

Re: [OpenJDK 2D-Dev] [9] Review Request: Cleanup of sun.java2d.pipe.Region

2016-05-12 Thread Jim Graham
This looks great! I guess the final was removed from the getters because the class is now final, though it probably doesn't hurt anything to leave them final. In any case, you only removed it from 3 of them, so it is unbalanced now. I suppose Hotspot is smart enough to inline accessors in a

[OpenJDK 2D-Dev] [9] Review Request: Cleanup of sun.java2d.pipe.Region

2016-05-12 Thread Sergey Bylokhov
Hello. Can somebody take a look to the proposed cleanup of sun.java2d.pipe.Region. When I worked on some bugs I got a situation when I tried to change the Region object via a different set methods. But these changes are ignored because the reference was to ImmutableRegion which replaces all s

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

2016-05-12 Thread Alexander Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8151303/webrev.01 There was a suggestion to postpone the fix for the issue 8152309 Seamless way of using image filters with multi-resolution images and continue with the current one: http://mail.openjdk.java.net/pi