Re: [OpenJDK 2D-Dev] RFR: 8149815: Misleading

Hello Bharath, Thank you for your comments. On May 10, 2016, at 8:45 AM, Bluv Nallakaluva wrote: > Please find my observations below on this. > > Even when hasDirectory is true for the TIFFField , the node returned by > TIFFField#getAsNativeNode does not return "TIFFIFD" value when the metho

Re: [OpenJDK 2D-Dev] Review Request: JDK-6587251 Import declaration not used in sun.java2d.*

+1 -phil. On 05/17/2016 03:38 AM, prasanta sadhukhan wrote: Looks good. Regards Prasanta On 5/17/2016 4:04 PM, Prem Balakrishnan wrote: Hi Prasanta, Thank you for the Review. Updated patch as per review comments. http://cr.openjdk.java.net/~pkbalakr/6587251/webrev.01/ Regards, Prem *Fro

[OpenJDK 2D-Dev] [9] RFR JDK-6509729: javax.print.ServiceUI.printDialog Border/Margin Evaluation is bugged

Hi All, Please review a fix for jdk9 whereby it is seen that the pagedialog margin validation is incorrect. Bug: https://bugs.openjdk.java.net/browse/JDK-6509729 webrev: http://cr.openjdk.java.net/~psadhukhan/6509729/webrev.00/ It is seen that if we modify right margin to invalid value like 0

Re: [OpenJDK 2D-Dev] Review Request: JDK-6587251 Import declaration not used in sun.java2d.*

Looks good. Regards Prasanta On 5/17/2016 4:04 PM, Prem Balakrishnan wrote: Hi Prasanta, Thank you for the Review. Updated patch as per review comments. http://cr.openjdk.java.net/~pkbalakr/6587251/webrev.01/ Regards, Prem *From

Re: [OpenJDK 2D-Dev] Review Request: JDK-6587251 Import declaration not used in sun.java2d.*

Hi Prasanta, Thank you for the Review. Updated patch as per review comments. http://cr.openjdk.java.net/~pkbalakr/6587251/webrev.01/ Regards, Prem From: prasanta sadhukhan Sent: Tuesday, May 17, 2016 3:33 PM To: Prem Balakrishnan; Philip Race; 2d-dev@openjdk.java.net Subject: Re:

Re: [OpenJDK 2D-Dev] Review Request: JDK-6587251 Import declaration not used in sun.java2d.*

Hi Prem, Looks good to me. Some files you have changed the copyright year, some files you have not like sun/java2d/pipe/OutlineTextRenderer.java, sun/java2d/pipe/LoopPipe.java although I do not think it is necessary to change manually, but please be consistent. Also, please put "noreg-cleanup"

[OpenJDK 2D-Dev] Review Request: JDK-6587251 Import declaration not used in sun.java2d.*

Hi, Please review fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-6587251 Webrev: http://cr.openjdk.java.net/~pkbalakr/6587251/webrev.00/ Removed unused Import declaration in sun.java2d.* Regards, Prem

[OpenJDK 2D-Dev] Review Request: JDK-6587251 Import declaration not used in sun.java2d.*

Hi, Please review fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-6587251 Webrev: http://cr.openjdk.java.net/~pkbalakr/6587251/webrev.00/ Removed unused Import declaration in sun.java2d.* Regards, Prem