Re: [OpenJDK 2D-Dev] Fix for JDK-8139192 : Custom ImageFilters return blank images in Java 8(.45) while working in 7

2016-05-30 Thread Ajit Ghaisas
I did contemplate catching 'Exception' instead of 'NullPointerException' while raising the webrev, but decided not to do it as- 1. Complaint in current image filter was due to NPE only 2. Catching & consuming generic exception does not seem quite correct here as we are just printing stack trace a

Re: [OpenJDK 2D-Dev] [9] Review Request: 8158072 Need a test for JDK-7172749

2016-05-30 Thread Alexey Ushakov
Looks good for me. Best Regards, Alexey > On 27 May 2016, at 22:36, Sergey Bylokhov wrote: > > On 27.05.16 22:17, Phil Race wrote: >> I suppose this will pass on the various platforms and pipelines since >> we've only seen the bug reported against xrender ? > > Long time ago we had the si

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4957035:Code given in api is not compilable: docs/api/javax/print/package-summary.html

2016-05-30 Thread Sergey Bylokhov
On 30.05.16 8:38, prasanta sadhukhan wrote: On 5/27/2016 5:22 PM, Sergey Bylokhov wrote: Looks fine, please add "noreg-doc" to the labels. I assume that there are no some other typos in this example which prevents compilation. I assume there is no need of ccc for this change, right? I think s

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4957035:Code given in api is not compilable: docs/api/javax/print/package-summary.html

2016-05-30 Thread Jayathirth D V
Hi Prasanta, Changes are fine. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Monday, May 30, 2016 11:20 PM To: prasanta sadhukhan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-4957035:Code given in api is not compilable: docs/api/javax/print/package-su