Re: [OpenJDK 2D-Dev] RFR: 8158408: Font2DTest demo needs to use FontPanel resolution matching the screen

On 01.06.16 21:44, Phil Race wrote: On 06/01/2016 11:05 AM, Semyon Sadetsky wrote: you call super.paintComponent(g); twice in lines 956 and 964. Is it expected behavior? Why the writePNG() produce the low resolution image? probably it should take into account the GC scale? Yes, if "Canno

Re: [OpenJDK 2D-Dev] Fix for JDK-8139192 : Custom ImageFilters return blank images in Java 8(.45) while working in 7

Thanks Jim and Phil for reviewing this. Adding a comment is a good suggestion. I have added it and requested a push of following webrev- http://cr.openjdk.java.net/~aghaisas/8139192/webrev.04/ (Sent here for a reference) Regards, Ajit -Original Message- From: Jim Graham Sent: Thursda

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

Hi Phil, We have to kind of images with which we are able to reproduce the issue: 1) sample.jpg present in JBS bug(We can't use this image because it is licensed ). 2) JpegEmbedThumbnail.jpg taken using Prasanta's camera and used in webrev. sample.jpg : If we do getNumI

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

Fixed typo. From: Jayathirth D V Sent: Thursday, June 02, 2016 5:08 PM To: Philip Race Cc: Jim Graham; 2d-dev@openjdk.java.net Subject: RE: Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail Hi Phil, We have two kind of im

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

Hi Phil, I have updated the code with all the changes I mentioned previously. I am caching hashCode when first time hashCode() is called. Please find the updated webrev for review: http://cr.openjdk.java.net/~jdv/7107905/webrev.09/ Thanks, Jay -Original Message- From: Philip Race Sent

[OpenJDK 2D-Dev] Review request for: JDK-8158495 CCE: sun.java2d.NullSurfaceData cannot be cast to sun.java2d.opengl.OGLSurfaceData

Hello Phil and Sergey, Here is one more fix of the ClassCastException for invalid surface that we’ve recently got in our products. I’ve updated Sergey’s test so it goes through the problematic code. Unfortunately, I was unable to reproduce the problem by myself (The actual issue was reported

Re: [OpenJDK 2D-Dev] Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

Hi, I faced merge issues while getting the webrev.00 committed. I have taken the latest code and merged webrev.00 changes on top of it to generate webrev.01. Here is the updated webrev. http://cr.openjdk.java.net/~aghaisas/8074829/webrev.01/ The changes are exactly the

Re: [OpenJDK 2D-Dev] Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

Makefile changes are still good. /Erik On 2016-06-02 18:10, Ajit Ghaisas wrote: Hi, I faced merge issues while getting the webrev.00 committed. I have taken the latest code and merged webrev.00 changes on top of it to generate webrev.01. Here is the updated webrev.

Re: [OpenJDK 2D-Dev] Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

+1 -phil. On 06/02/2016 09:10 AM, Ajit Ghaisas wrote: Hi, I faced merge issues while getting the webrev.00 committed. I have taken the latest code and merged webrev.00 changes on top of it to generate webrev.01. Here is the updated webrev. http://cr.openjdk.java.net

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

+1 -phil. On 06/02/2016 07:07 AM, Jayathirth D V wrote: Hi Phil, I have updated the code with all the changes I mentioned previously. I am caching hashCode when first time hashCode() is called. Please find the updated webrev for review: http://cr.openjdk.java.net/~jdv/7107905/webrev.09/ Tha

Re: [OpenJDK 2D-Dev] Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

+1 On 02.06.16 20:20, Phil Race wrote: +1 -phil. On 06/02/2016 09:10 AM, Ajit Ghaisas wrote: Hi, I faced merge issues while getting the webrev.00 committed. I have taken the latest code and merged webrev.00 changes on top of it to generate webrev.01. Here is the updated

Re: [OpenJDK 2D-Dev] Review request for: JDK-8158495 CCE: sun.java2d.NullSurfaceData cannot be cast to sun.java2d.opengl.OGLSurfaceData

+1 -phil. On 06/02/2016 08:07 AM, Alexey Ushakov wrote: Hello Phil and Sergey, Here is one more fix of the ClassCastException for invalid surface that we’ve recently got in our products. I’ve updated Sergey’s test so it goes through the problematic code. Unfortunately, I was unable to repro

Re: [OpenJDK 2D-Dev] Review request for: JDK-8158495 CCE: sun.java2d.NullSurfaceData cannot be cast to sun.java2d.opengl.OGLSurfaceData

Hi, Alexey. The code in OGLMaskFill.java is mirrored in D3DMaskFill for d3d, I think it should be updated also. It seems these files follow the rule: "80 chars per line", it will be good to do the same in the fix. On 02.06.16 18:07, Alexey Ushakov wrote: Hello Phil and Sergey, Here is one mo

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

I just noticed a hashCode/equals violation that we created a few revisions ago. We compute the hash of the validBits in ICM, but we only compare validBits up to the number of colors in the colormap. One could construct two ICMs that have different validBits that are identical in the first N bit

Re: [OpenJDK 2D-Dev] Fix for JDK-8139192 : Custom ImageFilters return blank images in Java 8(.45) while working in 7

Looks good! ...jim On 6/2/16 2:51 AM, Ajit Ghaisas wrote: Thanks Jim and Phil for reviewing this. Adding a comment is a good suggestion. I have added it and requested a push of following webrev- http://cr.openjdk.java.net/~aghaisas/8139192/webrev.04/ (Sent here for a reference