On 01.06.16 21:44, Phil Race wrote:
On 06/01/2016 11:05 AM, Semyon Sadetsky wrote:
you call super.paintComponent(g); twice in lines 956 and 964. Is it
expected behavior?
Why the writePNG() produce the low resolution image? probably it should
take into account the GC scale?
Yes, if "Canno
Thanks Jim and Phil for reviewing this.
Adding a comment is a good suggestion. I have added it and requested a push of
following webrev-
http://cr.openjdk.java.net/~aghaisas/8139192/webrev.04/
(Sent here for a reference)
Regards,
Ajit
-Original Message-
From: Jim Graham
Sent: Thursda
Hi Phil,
We have to kind of images with which we are able to reproduce the issue:
1) sample.jpg present in JBS bug(We can't use this image because it is
licensed ).
2) JpegEmbedThumbnail.jpg taken using Prasanta's camera and used in webrev.
sample.jpg :
If we do getNumI
Fixed typo.
From: Jayathirth D V
Sent: Thursday, June 02, 2016 5:08 PM
To: Philip Race
Cc: Jim Graham; 2d-dev@openjdk.java.net
Subject: RE: Review Request for JDK-8152672 : Exception while getting second
image properties for JPEG with embedded thumbnail
Hi Phil,
We have two kind of im
Hi Phil,
I have updated the code with all the changes I mentioned previously. I am
caching hashCode when first time hashCode() is called.
Please find the updated webrev for review:
http://cr.openjdk.java.net/~jdv/7107905/webrev.09/
Thanks,
Jay
-Original Message-
From: Philip Race
Sent
Hello Phil and Sergey,
Here is one more fix of the
ClassCastException for invalid surface that we’ve recently got in our products.
I’ve updated Sergey’s test so it goes through the problematic code.
Unfortunately, I was unable to reproduce the problem by myself (The actual
issue was reported
Hi,
I faced merge issues while getting the webrev.00 committed.
I have taken the latest code and merged webrev.00 changes on top of it to
generate webrev.01.
Here is the updated webrev.
http://cr.openjdk.java.net/~aghaisas/8074829/webrev.01/
The changes are exactly the
Makefile changes are still good.
/Erik
On 2016-06-02 18:10, Ajit Ghaisas wrote:
Hi,
I faced merge issues while getting the webrev.00 committed.
I have taken the latest code and merged webrev.00 changes on top of it to generate webrev.01.
Here is the updated webrev.
+1
-phil.
On 06/02/2016 09:10 AM, Ajit Ghaisas wrote:
Hi,
I faced merge issues while getting the webrev.00 committed.
I have taken the latest code and merged webrev.00 changes on top of it to generate webrev.01.
Here is the updated webrev.
http://cr.openjdk.java.net
+1
-phil.
On 06/02/2016 07:07 AM, Jayathirth D V wrote:
Hi Phil,
I have updated the code with all the changes I mentioned previously. I am
caching hashCode when first time hashCode() is called.
Please find the updated webrev for review:
http://cr.openjdk.java.net/~jdv/7107905/webrev.09/
Tha
+1
On 02.06.16 20:20, Phil Race wrote:
+1
-phil.
On 06/02/2016 09:10 AM, Ajit Ghaisas wrote:
Hi,
I faced merge issues while getting the webrev.00 committed.
I have taken the latest code and merged webrev.00 changes on
top of it to generate webrev.01.
Here is the updated
+1
-phil.
On 06/02/2016 08:07 AM, Alexey Ushakov wrote:
Hello Phil and Sergey,
Here is one more fix of the
ClassCastException for invalid surface that we’ve recently got in our products.
I’ve updated Sergey’s test so it goes through the problematic code.
Unfortunately, I was unable to repro
Hi, Alexey.
The code in OGLMaskFill.java is mirrored in D3DMaskFill for d3d, I think
it should be updated also. It seems these files follow the rule: "80
chars per line", it will be good to do the same in the fix.
On 02.06.16 18:07, Alexey Ushakov wrote:
Hello Phil and Sergey,
Here is one mo
I just noticed a hashCode/equals violation that we created a few revisions ago. We compute the hash of the validBits in
ICM, but we only compare validBits up to the number of colors in the colormap. One could construct two ICMs that have
different validBits that are identical in the first N bit
Looks good!
...jim
On 6/2/16 2:51 AM, Ajit Ghaisas wrote:
Thanks Jim and Phil for reviewing this.
Adding a comment is a good suggestion. I have added it and requested a push of
following webrev-
http://cr.openjdk.java.net/~aghaisas/8139192/webrev.04/
(Sent here for a reference
15 matches
Mail list logo