Re: [OpenJDK 2D-Dev] [9] RFR JDK-6601097:Margins are not reset to hardware margins when width/height is 0 or -ve alongwith x, y

I did say so long as the "ix/iy" are also valid. Which means not just positive but that they are not too large. Consider if (iw<= 0) iw = (float)(page.getPaper().getWidth()/DPI) - (ix*2); if we have ix = 500 and iw = -20 for a paper with width 800 this will result in iw = 800 - (500*2) = -200

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350:Empty pages when printing on Lexmark E352dn PS3 with "1200 IQ" setting

On 6/14/16, 10:09 PM, prasanta sadhukhan wrote: Hi Phil, On 6/15/2016 12:21 AM, Phil Race wrote: This sound fishy. "2" does not sound like a valid value per the Microsoft spec but this driver is apparently considering it as something like a multiplier although presumably not to the actual

[OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Hi, Please review this bug fix for the Marlin renderer to improve the array caches, its usages but also the renderer stats: bug: https://bugs.openjdk.java.net/browse/JDK-8159638 webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8159638.0/ This patch also reduces slightly the memory

Re: [OpenJDK 2D-Dev] RFR 8159093: Fix coding conventions in Marlin renderer

+1 -phil. On 06/13/2016 04:31 AM, Laurent Bourgès wrote: Jim, This MT issue concerns only statistics collection so I deliberately did not ensure thread safety to avoid a synchronized block as the code is still "safe". Anyway I can fix it in the next patch that will improve array cache

[OpenJDK 2D-Dev] (Review request) JDK-8152971: -Xcheck:jni warning

Hello Everyone on Java2D group Good day to you. Please find herewith, webrev with changes to fix the following issue: Bug ID / Title : JDK-8152971 -Xcheck:jni - WARNING in native method Bug Link : https://bugs.openjdk.java.net/browse/JDK-8152971 Description on Bug : .

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6218397:Printing to file does not throw a PrinterException if the file cannot be created

If this is executed on Windows (shared Postscript stream printer could do this) then since the output stream is still open I expect the delete will fail. Attempt to close the open stream first (in a try .. catch I suppose). -phil. On 6/15/16, 3:25 AM, prasanta sadhukhan wrote: Hi All, Bug:

[OpenJDK 2D-Dev] [9] RFR JDK-6218397:Printing to file does not throw a PrinterException if the file cannot be created

Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-6218397 The issue was if the linux disk is full and we are trying to "print to file" then PrinterException is not thrown and a 0 byte file is created. Although I am not able to reproduce this behaviour, because when I make my disk full

Re: [OpenJDK 2D-Dev] Review Request for JDK-6386906 : Faulty rounding code in BMPImageReader.decodeRLE4()

+1 Regards Prasanta On 6/15/2016 12:23 PM, Jayathirth D V wrote: Hi Jim, Thanks for the review. I have updated the webrev for reference: http://cr.openjdk.java.net/~jdv/6386906/webrev.02/ Thanks, Jay -Original Message- From: Jim Graham Sent: Wednesday, June 15, 2016 4:15 AM To:

Re: [OpenJDK 2D-Dev] Review Request for JDK-6386906 : Faulty rounding code in BMPImageReader.decodeRLE4()

Hi Jim, Thanks for the review. I have updated the webrev for reference: http://cr.openjdk.java.net/~jdv/6386906/webrev.02/ Thanks, Jay -Original Message- From: Jim Graham Sent: Wednesday, June 15, 2016 4:15 AM To: Jayathirth D V; 2d-dev@openjdk.java.net; Philip Race Subject: Re: