Re: [OpenJDK 2D-Dev] Review Request for JDK-7059970 : Test case: javax/imageio/plugins/png/ITXtTest.java is not closing a file

Hi Phil and Brian, Thanks for your inputs. I have made following updates: 1) Added new bug-id in the test case. 2) Using try-with-resources for closing streams. I can't perform f.delete() in finally block of writeTo() and readFrom() because "test.png" is shared resource betwe

[OpenJDK 2D-Dev] [9] RFR 8160888: [PIT] What to expect of updated java/awt/print/PrinterJob/Margins.java

Hi All, Please find an updation of the testcase Bug: https://bugs.openjdk.java.net/browse/JDK-8160888 webrev: http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.00/ where the testcase was made automated and specifically pass mediasize=A4 as attributes so that there is no ambiguity of using

Re: [OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile option is not disabled for flavors that do not support destination

Hi Prasanta, Since CUPS is not used in Windows, your change will not make difference if I run the test in Windows. Please add @requires tag in jtreg test case and there are some lines which are 80 character plus. Also please add null check when you create PrinterService in test case.

[OpenJDK 2D-Dev] REG : JDK-8160943 : [PIT] new failure of closed/javax/imageio/ReadAllThumbnailsTest.java

Hi, In HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8152672"JDK-8152672 we modified skipImage() in JpegImageReader.java and added tighter checks for parsing Jpeg data. We have to find any marker,0 or EOF after we find "FF" while parsing JPEG data. But in HYPERLINK "https://bugs.op

Re: [OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile option is not disabled for flavors that do not support destination

Hi Jay, Thanks for pointing that out. Modified testcase to run in linux only and added check to fail if no printer service is found. http://cr.openjdk.java.net/~psadhukhan/5049012/webrev.03/ Regards Prasanta On 7/8/2016 4:00 PM, Jayathirth D V wrote: Hi Prasanta, Since CUPS is not used in W

Re: [OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile option is not disabled for flavors that do not support destination

Hi Prasanta, Changes are fine. Thanks, Jay From: Prasanta Sadhukhan Sent: Friday, July 08, 2016 4:42 PM To: Jayathirth D V Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile option is not disabled for flavors that do not support destination Hi Jay, Thanks

Re: [OpenJDK 2D-Dev] Review Request for JDK-7059970 : Test case: javax/imageio/plugins/png/ITXtTest.java is not closing a file

Hi Jay, Sorry to be picky here but in doTest() could you not instead have try { writeTo(file, src); ITXtTest dst = readFrom(file); if (dst == null || !dst.equals(src)) { throw new RuntimeException("Test failed."); } }

Re: [OpenJDK 2D-Dev] REG : JDK-8160943 : [PIT] new failure of closed/javax/imageio/ReadAllThumbnailsTest.java

On 07/08/2016 04:08 AM, Jayathirth D V wrote: Hi, In JDK-8152672 we modified skipImage() in JpegImageReader.java and added tighter checks for parsing Jpeg data. We have to find any marker,0 or EOF after we find "FF" while parsing JPEG data