Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

2016-07-19 Thread Jim Graham
Hi Laurent, Some work should be done on the comments at the top of ArrayCache.java - line 38 and 42 make the same claim about 2 different thresholds. It seems silly, but in ArrayCache.getNewLargeSize(), lines 162 and 164 are both ">" tests and then the newly added test at 166 is a "<" test.

Re: [OpenJDK 2D-Dev] RFR: 8161407: Provide a javadoc description for java.desktop module

2016-07-19 Thread Sergey Bylokhov
On 18.07.16 22:11, Phil Race wrote: "User interface, graphics and imaging APIs" Any objection to that ? What about a11y and sound? -phil. On 07/18/2016 11:22 AM, Brian Burkhalter wrote: Showing my own bias, how about “UI and graphics APIs” -> “graphics, imaging, and user interface APIs”

Re: [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

2016-07-19 Thread Sergey Bylokhov
Look fine to me. On 07.07.16 18:01, Lindenmaier, Goetz wrote: Hi, This change is ‘L’ because there are changes to a lot of files, but the changes are all similar, so it’s rather easy to review. Similar to 8159690 I added @key headful to another around 600 tests. I used different patterns t

Re: [OpenJDK 2D-Dev] Review Request for JDK-8160943 : [PIT] new failure of closed/javax/imageio/ReadAllThumbnailsTest.java

2016-07-19 Thread Jayathirth D V
Hi Phil, I generated Jpeg image with thumbnail as given in test case attached for https://bugs.openjdk.java.net/browse/JDK-4958271 with JDK 9. The image has only two APP0 markers and after the second marker it has "00 FF" which we can consider as "X FF" as per https://www.w3.org/Graphics/JPEG/i

Re: [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

2016-07-19 Thread Lindenmaier, Goetz
Hi Sergey, thanks a lot for looking at this! Best regards, Goetz. > -Original Message- > From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com] > Sent: Tuesday, July 19, 2016 9:17 PM > To: Lindenmaier, Goetz ; awt- > d...@openjdk.java.net; swing-...@openjdk.java.net; 2d-dev <2d- > d

Re: [OpenJDK 2D-Dev] [9] RFR 8160888: [PIT] What to expect of updated java/awt/print/PrinterJob/Margins.java

2016-07-19 Thread Prasanta Sadhukhan
I have updated the webrev to remove run only on windows jtreg tag as with the fix proposed for 6574279: validatePage from PrinterJob returns argument under linux the printed margin will be of correct value and not the full imageablearea(0,0,paperwidth,paperheight) so the issue will be seen on wi