[OpenJDK 2D-Dev] RFR: 7175487: Cannot customize font configuration on Linux

2016-07-21 Thread Phil Race
https://bugs.openjdk.java.net/browse/JDK-7175487 http://cr.openjdk.java.net/~prr/7175487/ As I note in the bug eval the probable issue here is that the file was found but rejected. I've made the code more forgiving by removing the test that the file have references to font files. The XLFD

Re: [OpenJDK 2D-Dev] RFR (urgent) 8162097: [PIT] A series of closed tests about SunFontManager throw NPE on Windows

2016-07-21 Thread Sergey Bylokhov
+1 On 21.07.16 20:54, Brian Burkhalter wrote: This looks fine as far as I can see. Brian On Jul 21, 2016, at 9:57 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8162097/ I have an urgent RFR which is blocking PIT. The fix :

Re: [OpenJDK 2D-Dev] Review Request for JDK-8160943 : [PIT] new failure of closed/javax/imageio/ReadAllThumbnailsTest.java

2016-07-21 Thread Jayathirth D V
Hi Jim, I just ran the test case attached in https://bugs.openjdk.java.net/browse/JDK-4958271 . It is actually generating an image and using it to do reader.readAll(). Thanks, Jay -Original Message- From: Jim Graham Sent: Thursday, July 21, 2016 2:22 PM To: Jayathirth D V; Philip Race

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

2016-07-21 Thread Jim Graham
Looks good to me... ...jim On 07/20/2016 09:53 AM, Jayathirth D V wrote: Hi Jim, Thanks for your input. I have updated specification of ColorModel and its subclasses. Please find new webrev for review: http://cr.openjdk.java.net/~jdv/7107905/webrev.13/ Thanks, Jay

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

2016-07-21 Thread Jim Graham
Hi Laurent, On 07/21/2016 06:56 AM, Laurent Bourgès wrote: I don't have any issues with those numbers, but the way that they are calculated makes it look like they are supposed to be unique numbers and yet through the obscurity of the loops used to populate the sizes they just

Re: [OpenJDK 2D-Dev] Review Request for JDK-8160943 : [PIT] new failure of closed/javax/imageio/ReadAllThumbnailsTest.java

2016-07-21 Thread Jim Graham
Hi Jay, How did you generate that image with thumbnail? With ImageIO? ...jim On 07/19/2016 12:18 PM, Jayathirth D V wrote: Hi Phil, I generated Jpeg image with thumbnail as given in test case attached for https://bugs.openjdk.java.net/browse/JDK-4958271 with JDK 9.

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

2016-07-21 Thread Phil Race
OK by me. -phil. On 07/20/2016 09:53 AM, Jayathirth D V wrote: Hi Jim, Thanks for your input. I have updated specification of ColorModel and its subclasses. Please find new webrev for review: http://cr.openjdk.java.net/~jdv/7107905/webrev.13/ Thanks, Jay -Original Message- From: Jim

Re: [OpenJDK 2D-Dev] RFR (urgent) 8162097: [PIT] A series of closed tests about SunFontManager throw NPE on Windows

2016-07-21 Thread Brian Burkhalter
This looks fine as far as I can see. Brian On Jul 21, 2016, at 9:57 AM, Phil Race wrote: > http://cr.openjdk.java.net/~prr/8162097/ > > I have an urgent RFR which is blocking PIT. > > The fix : https://bugs.openjdk.java.net/browse/JDK-8152971 to eliminate some > JNI

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4882305: StreamPrintServ.getSupportedAttributeValues returns null for Orientation attr

2016-07-21 Thread Jayathirth D V
Hi Prasanta,   You have many lines of commented code in test case, which is not needed. Also there are cases of null pointer dereferencing at line 68 & 70 in test case. Please add checks for the same. And you can add bug evaluation in JBS for the same.   Thanks, Jay   From: Philip Race

[OpenJDK 2D-Dev] RFR (urgent) 8162097: [PIT] A series of closed tests about SunFontManager throw NPE on Windows

2016-07-21 Thread Phil Race
http://cr.openjdk.java.net/~prr/8162097/ I have an urgent RFR which is blocking PIT. The fix : https://bugs.openjdk.java.net/browse/JDK-8152971 to eliminate some JNI warnings. is prematurely deleting a local ref which is used in a callback function. As as result we get many NPEs in Java

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

2016-07-21 Thread Laurent Bourgès
Dear Jim, Thanks for your review, I'll answer your questions in the text below and will later propose a new webrev: 2016-07-19 9:00 GMT+02:00 Jim Graham : > > Some work should be done on the comments at the top of ArrayCache.java - > line 38 and 42 make the same claim