Re: [OpenJDK 2D-Dev] [9] Review request for 8160124 SunGraphics2D.hitClip() can give wrong result for floating point scale

2016-07-26 Thread Jim Graham
Ah, this is an issue of what an empty rectangle means. Filling 1.5,1.5,0,0 produces no output because it has no interior. But, stroking 1.5,1.5,0,0 can produce output because it is simply a rectangle that spins in place. As a result there are really 3 different containment properties for a r

Re: [OpenJDK 2D-Dev] [9] Review request for 8160124 SunGraphics2D.hitClip() can give wrong result for floating point scale

2016-07-26 Thread Sergey Bylokhov
On 13.07.16 5:42, Jim Graham wrote: What does the compClip end up being in that case? BufferedImage bi = new BufferedImage(10,10,BufferedImage.TYPE_INT_ARGB); SunGraphics2D graphics = (SunGraphics2D) bi.createGraphics(); graphics.scale(1.5, 1.5); graphics.setCl

Re: [OpenJDK 2D-Dev] RFR: 8162429: Clean up obsolete font preferences for JDS.

2016-07-26 Thread Jennifer Godinez
Looks good. Jennifer On 7/22/2016 1:02 PM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8162429 http://cr.openjdk.java.net/~prr/8162429/ Clean up some now obsolete font code. -phil.

Re: [OpenJDK 2D-Dev] RFR: 8162545: Mac build failure

2016-07-26 Thread Phil Race
Not that strange considering it was just pushed a few hours ago. I'll have to merge these before pushing my fix .. -phil. On 07/26/2016 08:10 AM, Prasanta Sadhukhan wrote: Looks good. But strangely, I do not see this function in this file when Phil sent for review for his disable warning fix

Re: [OpenJDK 2D-Dev] RFR: 8162545: Mac build failure

2016-07-26 Thread Vadim Pakhnushev
I checked that this fix passes JPRT with Phil's fix as well. Vadim On 26.07.2016 18:10, Prasanta Sadhukhan wrote: Looks good. But strangely, I do not see this function in this file when Phil sent for review for his disable warning fix ;-) Regards Prasanta On 7/26/2016 8:20 PM, Vadim Pakhnush

Re: [OpenJDK 2D-Dev] RFR: 8162545: Mac build failure

2016-07-26 Thread Phil Race
+1 -phil. On 07/26/2016 07:50 AM, Vadim Pakhnushev wrote: Hi all, Please review the build failure fix for: https://bugs.openjdk.java.net/browse/JDK-8162545 diff -r c0cf6ec85273 src/java.desktop/share/native/libjavajpeg/imageioJPEG.c --- a/src/java.desktop/share/native/libjavajpeg/imageioJPEG

Re: [OpenJDK 2D-Dev] RFR: 8162545: Mac build failure

2016-07-26 Thread Prasanta Sadhukhan
Looks good. But strangely, I do not see this function in this file when Phil sent for review for his disable warning fix ;-) Regards Prasanta On 7/26/2016 8:20 PM, Vadim Pakhnushev wrote: Hi all, Please review the build failure fix for: https://bugs.openjdk.java.net/browse/JDK-8162545 diff -

[OpenJDK 2D-Dev] RFR: 8162545: Mac build failure

2016-07-26 Thread Vadim Pakhnushev
Hi all, Please review the build failure fix for: https://bugs.openjdk.java.net/browse/JDK-8162545 diff -r c0cf6ec85273 src/java.desktop/share/native/libjavajpeg/imageioJPEG.c --- a/src/java.desktop/share/native/libjavajpeg/imageioJPEG.c Tue Jul 26 15:55:22 2016 +0300 +++ b/src/java.desktop/shar

Re: [OpenJDK 2D-Dev] RFR: 8074827: Resolve disabled warnings for libjavajpeg

2016-07-26 Thread Sergey Bylokhov
+1 On 26.07.16 9:03, Prasanta Sadhukhan wrote: Looks good. Regards Prasanta On 7/26/2016 11:10 AM, Philip Race wrote: https://bugs.openjdk.java.net/browse/JDK-8074827 http://cr.openjdk.java.net/~prr/8074827/ Passes JPRT. gcc clobbered is left since that seems to be a gcc bug fixed in a later