Yes, right. Please find the modified webrev:
http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.02/
Regards
Prasanta
On 7/28/2016 7:10 PM, Philip Race wrote:
This can now be written more succinctly (and clearly) as :
prPgRngSupported =psCurrent.isAttributeValueSupported(prAll,
docFlavor, asC
Bug: https://bugs.openjdk.java.net/browse/JDK-8074843
Fix: http://cr.openjdk.java.net/~prr/8074843/
Here's a sampling of the warnings that I think covers most, maybe all,
of the cases
LINUX
mlib_ImageAffine_NN_Bit.c:87:81: error: suggest parentheses around '-'
in operand of '&' [-Werror=parent
These classes are a mess.
CSM has numBands, but so does the super class. We should probably
delete the copy in the subclass.
CSM constructors re-initialize data members that were already
initialized in the super() constructor.
CSM.equals() and hashCode() include code that really should bel
right .. when we talked off-line yesterday I said that if IPP is reporting
a default we should honour it. The default of standard/on is only for
the case we do not use IPP or it reports nothing.
if (noJobSheet) {
885 pFlags |= NOSHEET;
886 ncomps+=1;
887 } else {
888 nc
This can now be written more succinctly (and clearly) as :
prPgRngSupported = psCurrent.isAttributeValueSupported(prAll,
docFlavor,asCurrent);
-phil.
On 7/28/16, 3:27 AM, Prasanta Sadhukhan wrote:
Trying to be extra cautious. Please find modified webrev:
http://cr.openjdk.java.net/~psadhukh
There's usually some fairly lengthy processing going on
in the layout code so I think it would be too long to hold
a critical lock and not likely to show a detectable benefit.
Also I think it possible we may make some Java upcalls there ..
-phil.
On 7/28/16, 5:41 AM, Sergey Bylokhov wrote:
Look
Looks fine.
I wander is it possible to improve it via
GetPrimitiveArrayCritical/ReleasePrimitiveArrayCritical?
On 28.07.16 1:06, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8158477
http://cr.openjdk.java.net/~prr/8158477/
Missing a call to ReleaseCharArrayElements()
With this
Hi,
We can follow the same approach of what we did in ColorModel.equals() for
JDK-7107905.
We can use getClass() check in ComponentSampleModel.equals() to differentiate
between BandedSampleModel and PixelInterleavedSampleModel in rare cases where
they can have same values and remove the need f
Looks ok.
Regards
Prasanta
On 7/28/2016 3:04 PM, Sergey Bylokhov wrote:
Looks fine.
On 28.07.16 0:12, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8056210
http://cr.openjdk.java.net/~prr/8056210/
Simple clean-up of moving code used only on windows into a windows
source directory
Trying to be extra cautious. Please find modified webrev:
http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.01/
Regards
Prasanta
On 7/27/2016 9:55 PM, Phil Race wrote:
prAll is final and initalised. So why are you testing !=null ?
-phil.
On 07/05/2016 02:08 AM, Prasanta Sadhukhan wrote:
H
The banner checkbox is not enabled initially as it calls
getDefaultAttributeValue() and it seems printer is reporting the default
job-sheet value as "none" so the below check is not satisfied.
cbJobSheets.setSelected(js != JobSheets.NONE);
When IPPPrintService#readIPPResponse() is called, it in
Looks fine.
On 28.07.16 0:12, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8056210
http://cr.openjdk.java.net/~prr/8056210/
Simple clean-up of moving code used only on windows into a windows
source directory
JPRT is happy ..
-phil.
--
Best regards, Sergey.
12 matches
Mail list logo
