Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

That's what warning said: "place parentheses *around the assignment *to silence this warning" Vadim On 02.08.2016 8:48, Prasanta Sadhukhan wrote: +1. Only one thing, mlib_c_ImageCopy.c#185 do we really need that extra parentheses, ((j = (w & 1))). I guess this should just do if (j = (w & 1)),

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

+1. Only one thing, mlib_c_ImageCopy.c#185 do we really need that extra parentheses, ((j = (w & 1))). I guess this should just do if (j = (w & 1)), isn't it? Regards Prasanta On 8/1/2016 10:43 PM, Phil Race wrote: Looking for another "+1" ... -phil. On 07/29/2016 10:13 PM, Vadim Pakhnushev w

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Hi Laurent, A tip on webrevs, if you supply a file of filenames then you can tell it to diff a file with a name change against its former name by using 2 filenames on the same line, as in: filetodiff1.java filetodiff2.java filetodiff3.java filetodiff3oldname.java filetodiff4.java ---

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Hi Jim, Here is an updated webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8159638.1/ Changes: - merge Clean/Dirty Xxx ArrayCache using the flag 'clean' to indicate if the cache is clean or dirty + the putArray method always performs the array cleanup - ArrayCache renamed to ArrayCache

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8160943 : skipImage() in JPEGImageReader class throws IIOException if we have gaps between markers in Jpeg image

Hi Jay, This looks good... ...jim On 8/1/16 1:26 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8160943 Webrev : http://cr.openjdk.java.net/~jdv/8160943/webrev.00/ Root

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

+1 for the review with a preference for Vadim’s suggestion. Brian On Aug 1, 2016, at 10:15 AM, Phil Race wrote: > That would be fine too. The main thing was getting rid of Class.forName > > -phil. > > On 08/01/2016 10:19 AM, Vadim Pakhnushev wrote: >> Why not just registry.getServiceProviders

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

That would be fine too. The main thing was getting rid of Class.forName -phil. On 08/01/2016 10:19 AM, Vadim Pakhnushev wrote: Why not just registry.getServiceProviders(ImageReaderSpi.class, ? Vadim On 01.08.2016 19:13, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at y

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

Looking for another "+1" ... -phil. On 07/29/2016 10:13 PM, Vadim Pakhnushev wrote: Looks good! Vadim On 30.07.2016 6:49, Philip Race wrote: See http://cr.openjdk.java.net/~prr/8074843.1/ Also passes JPRT -phil. On 7/29/16, 7:35 AM, Vadim Pakhnushev wrote: On 29.07.2016 17:30, Philip Rac

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

Why not just registry.getServiceProviders(ImageReaderSpi.class, ? Vadim On 01.08.2016 19:13, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience : Bug : https://bugs.openjdk.java.net/browse/JDK-8160736 Webrev : http://cr.openjdk.java.net/~jdv/8160736/webrev

[OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

Hi, Please review the following fix in JDK9 at your convenience : Bug : https://bugs.openjdk.java.net/browse/JDK-8160736 Webrev : http://cr.openjdk.java.net/~jdv/8160736/webrev.00/ Root Cause : KSS tool has detected usage of class.forName where it can be avoided. Solution : Use in

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

+1 -phil On 8/1/16, 9:13 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience : Bug : https://bugs.openjdk.java.net/browse/JDK-8160736 Webrev : http://cr.openjdk.java.net/~jdv/8160736/webrev.00/ R

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8160943 : skipImage() in JPEGImageReader class throws IIOException if we have gaps between markers in Jpeg image

Hi Phil, Thanks for your review. I have run all jtreg tests under imageio and there are no side effects. Thanks, Jay From: Philip Race Sent: Monday, August 01, 2016 7:22 PM To: Jayathirth D V Cc: Jim Graham; Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9

Re: [OpenJDK 2D-Dev] Fwd: JDK bug 8078516

Transparency of the surface has always disabled LCD sub-pixel in Java 2D. Same happens on windows. The labels at the bottom are drawn in greyscale. -phil. On 8/1/16, 7:55 AM, Torgeir Veimo wrote: Ok, am asking since subpixel rendering works and is usable in most situations, except for the odd c

Re: [OpenJDK 2D-Dev] Fwd: JDK bug 8078516

Ok, am asking since subpixel rendering works and is usable in most situations, except for the odd corner case when drawing over existing content in transparent surfaces. See eg. this screenshot of netbeans, with nice subpixel rendered text in the editor, while the labels on the buttons at the bott

Re: [OpenJDK 2D-Dev] Fwd: JDK bug 8078516

Phil will be able to comment on this further. All I can confirm is that 8078526 is closed as a duplicate of 8087201, so it is no longer an open bug. -- Kevin Torgeir Veimo wrote: I'm fairly sure it's the correct bug id, although I don't have access to view it myself. Bug 8078526 is about su

[OpenJDK 2D-Dev] Fwd: JDK bug 8078516

I'm fairly sure it's the correct bug id, although I don't have access to view it myself. Bug 8078526 is about supporting (without artifacts) subpixel rendering to transparent surfaces. Bug 8087201 is about speeding up subpixel rendering. On 2 August 2016 at 00:39, Kevin Rushforth wrote: > Are

Re: [OpenJDK 2D-Dev] JDK bug 8078516

Are you sure you have the right Bug ID? That bug (which is not publicly visible), is closed as a duplicate of 8087201, which was fixed in JDK 9 and 8u66 over a year ago. -- Kevin Torgeir Veimo wrote: Is there any more work done on JDK bug 8078516? -- -Tor

[OpenJDK 2D-Dev] JDK bug 8078516

Is there any more work done on JDK bug 8078516? -- -Tor

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8160943 : skipImage() in JPEGImageReader class throws IIOException if we have gaps between markers in Jpeg image

+1 - assuming you have run the jtreg tests for imageio .. -phil. On 8/1/16, 1:26 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8160943 Webrev : http://cr.openjdk.java.net/~jdv/8160943/webrev.00/

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6575247: Banner checkbox in PrinterJob print dialog doesn't work

Ok. +1 -phil On 8/1/16, 2:06 AM, Prasanta Sadhukhan wrote: On 7/28/2016 9:19 PM, Phil Race wrote: right .. when we talked off-line yesterday I said that if IPP is reporting a default we should honour it. The default of standard/on is only for the case we do not use IPP or it reports nothing

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6575247: Banner checkbox in PrinterJob print dialog doesn't work

On 7/28/2016 9:19 PM, Phil Race wrote: right .. when we talked off-line yesterday I said that if IPP is reporting a default we should honour it. The default of standard/on is only for the case we do not use IPP or it reports nothing. if (noJobSheet) { 885 pFlags |= NOSHEET; 886

[OpenJDK 2D-Dev] [9] RFR: JDK-8160943 : skipImage() in JPEGImageReader class throws IIOException if we have gaps between markers in Jpeg image

Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8160943 Webrev : http://cr.openjdk.java.net/~jdv/8160943/webrev.00/ Root cause : While fixing JDK-8152672 we considered that there can be no data in Jpeg image which can b