Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

I think that sounds reasonable. -Phil. > On Aug 2, 2016, at 5:28 PM, Jim Graham wrote: > > How about instead of the shell script we put a comment up at the top of the > files (after the copyright header), with the appropriate command line? > Something like: > > /* > * Note that the Byte/Int

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

How about instead of the shell script we put a comment up at the top of the files (after the copyright header), with the appropriate command line? Something like: /* * Note that the Byte/Int/Float files are nearly identical except * for a few type and name differences. Typically, the Byte v

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

Well I already checked in but I did notice that alignment issue and fixed that before pushing. -phil. On 8/2/16, 3:10 PM, Jim Graham wrote: Also, fix the line of "\" at the right edge of the source and add {} around the body of the if statement... ...jim On 08/02/2016 03:06 PM, V

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

I have not yet looked at everything but no issues except that I find checking in the shell script a bit weird. Not to mention its technically a "source file" so should have a license. -phil. On 8/2/16, 2:56 PM, Jim Graham wrote: Thanks Laurent, On 08/02/2016 05:57 AM, Laurent Bourgès wrote: T

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

I agree as well. Assignments really aren't ever needed inside if statements... ...jim On 08/02/2016 03:06 PM, Vadim Pakhnushev wrote: Or as j = w & 1; if (j != 0) { as in other longer cases. Too much parentheses to my taste. Vadim On 03.08.2016 1:04, Jim Graham wrote

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

Or as j = w & 1; if (j != 0) { as in other longer cases. Too much parentheses to my taste. Vadim On 03.08.2016 1:04, Jim Graham wrote: In that case, then I'd write it as "if ((j = (w & 1)) != 0)" to make it clear that the LHS is an assignment. A casual reading of the code might see this as a

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

Also, fix the line of "\" at the right edge of the source and add {} around the body of the if statement... ...jim On 08/02/2016 03:06 PM, Vadim Pakhnushev wrote: Or as j = w & 1; if (j != 0) { as in other longer cases. Too much parentheses to my taste. Vadim On 03.08

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

In that case, then I'd write it as "if ((j = (w & 1)) != 0)" to make it clear that the LHS is an assignment. A casual reading of the code might see this as a comparison with an extra set of parentheses until someone counts the equal signs... ...jim On 08/02/2016 10:38

Re: [OpenJDK 2D-Dev] [9] Review request for 8160124 SunGraphics2D.hitClip() can give wrong result for floating point scale

On 08/02/2016 10:36 AM, Sergey Bylokhov wrote: On 27.07.16 1:56, Jim Graham wrote: Rectangle2D rClip = (Rectangle2D) usrClip; int x0 = (int) Math.ceil(rClip.getMinX() - 0.5); int y0 = (int) Math.ceil(rClip.getMinY() - 0.5); int x1 = (int) Math.ceil(rClip.getMaxX() - 0.5); int x1 = (int) Math.cei

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Thanks Laurent, On 08/02/2016 05:57 AM, Laurent Bourgès wrote: Thanks for the tip, I made another webrev (for archive) that shows the proper diffs in ArrayCache / ArrayCacheConst: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8159638.1_bis/

Re: [OpenJDK 2D-Dev] [9] RFR JDK-5080098: Page Range must be disabled on the common print dlg for Non serv-formatted flvrs

+1 -phil On 7/28/16, 10:28 PM, Prasanta Sadhukhan wrote: Yes, right. Please find the modified webrev: http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.02/ Regards Prasanta On 7/28/2016 7:10 PM, Philip Race wrote: This can now be written more succinctly (and clearly) as : prPgRngSupported

Re: [OpenJDK 2D-Dev] [9] Fix for JDK-6427331 : NullPointerException in LookupOp.filter(Raster, WritableRaster)

+1. -phil. On 8/2/16, 2:01 AM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-6427331 Issue : If destination raster is provided as null to java.awt.image.LookupOp.filter(Raster src, WritableRaster dest), according to Javadoc, a new raster sh

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

On 08/01/2016 10:48 PM, Prasanta Sadhukhan wrote: +1. Only one thing, mlib_c_ImageCopy.c#185 do we really need that extra parentheses, ((j = (w & 1))). I guess this should just do if (j = (w & 1)), isn't it? I originally tried exactly that but the compiler still complained and did insist on w

Re: [OpenJDK 2D-Dev] [9] Review request for 8160124 SunGraphics2D.hitClip() can give wrong result for floating point scale

On 27.07.16 1:56, Jim Graham wrote: Rectangle2D rClip = (Rectangle2D) usrClip; int x0 = (int) Math.ceil(rClip.getMinX() - 0.5); int y0 = (int) Math.ceil(rClip.getMinY() - 0.5); int x1 = (int) Math.ceil(rClip.getMaxX() - 0.5); int x1 = (int) Math.ceil(rClip.getMaxY() - 0.5); clipRegion = devClip.g

Re: [OpenJDK 2D-Dev] Fwd: JDK bug 8078516

Yes ... offline to Torgeir I questioned the closing as a dup. Need to look at these carefully to see if we should reopen or file a new issue but it would be an enhancement request, not a bug. -phil. On 8/2/16, 9:07 AM, Sergey Bylokhov wrote: I suppose that this is why JDK-8078516 was filed, and

Re: [OpenJDK 2D-Dev] Fwd: JDK bug 8078516

I suppose that this is why JDK-8078516 was filed, and it was closed as a duplicate, because another bug provided a way to use LCD rendering on OSX to opaque surface + workaround in swing, fixed the bug of the submitter. Probably we should file another bug as a replacement of 8078516. On 01.08

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Hi Jim, A tip on webrevs, if you supply a file of filenames then you can tell it to > diff a file with a name change against its former name by using 2 filenames > on the same line, as in: > > > filetodiff1.java > filetodiff2.java > filetodiff3.java filetodiff3oldname.java > filetodiff4.j

Re: [OpenJDK 2D-Dev] [9] Fix for JDK-6427331 : NullPointerException in LookupOp.filter(Raster, WritableRaster)

Thanks Prasanta. I checked filter() methods of following classes - AffineTransformOp, ColorConvertOp, ConvolveOp, LookupOp, RescaleOp and BandCombineOp. They do not have this issue of accessing null destination buffer/raster. From: Prasanta Sadhukhan Sent: Tuesday, August 02, 2016 2:59 PM

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

Hi, Thanks for the review. Yes we can use it directly in the argument of getServiceProviders() API. Please find updated webrev for reference: http://cr.openjdk.java.net/~jdv/8160736/webrev.01/ I will be pushing the updated change into repo. Regards, Jay From: Brian Burkhalter

Re: [OpenJDK 2D-Dev] [9] Fix for JDK-6427331 : NullPointerException in LookupOp.filter(Raster, WritableRaster)

+1. Just check other op file like Rescale, Convolve if similar problem exists there too. Regards Prasanta On 8/2/2016 2:31 PM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-6427331 Issue : If destination raster is provided as null to java.awt.image.LookupOp.f

[OpenJDK 2D-Dev] [9] Fix for JDK-6427331 : NullPointerException in LookupOp.filter(Raster, WritableRaster)

Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-6427331 Issue : If destination raster is provided as null to java.awt.image.LookupOp.filter(Raster src, WritableRaster dest), according to Javadoc, a new raster should be created. Instead, it results in NullPointerExc