Re: [OpenJDK 2D-Dev] RFR: JDK-8155960: TIFF javadoc contains HTML entities inside {@code} tags

+1 (and one reviewer is enough for this minor doc fix). -phil. On 8/3/16, 3:58 PM, Brian Burkhalter wrote: Please review at your convenience. Issue:https://bugs.openjdk.java.net/browse/JDK-8155960 Patch:[1] Note that the portion of this issue in javax.imageio.plugins.tiff was resolved as

[OpenJDK 2D-Dev] RFR: JDK-8155960: TIFF javadoc contains HTML entities inside {@code} tags

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8155960 Patch: [1] Note that the portion of this issue in javax.imageio.plugins.tiff was resolved as part of the fix for https://bugs.openjdk.java.net/browse/JDK-8149016. Thanks, Brian [1] diff ---

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

High-level question. Why is this not an over-ride in PSPrinterJob ? I'm afraid I did not get much past the first line of the change : 1662 MediaPrintableArea mpa = 1663 (MediaPrintableArea)getPrintService(). 1664

Re: [OpenJDK 2D-Dev] RFR: JDK-8163102: Fix headless only configuration option

Hi Erik, On 4/08/2016 1:04 AM, Erik Joelsson wrote: Hello, The current --disable-headful option is weird. Even worse, it doesn't work since the makefiles still uses the legacy BUILD_HEADLESS_ONLY variable, which configure never touches. The confusion around that variable due to its legacy

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

If that's the only change then it looks good to me... ...jim On 08/03/2016 02:58 AM, Laurent Bourgès wrote: Jim & Phil, I added the following class header in Byte/Int/Float ArrayCache classes and removed the shell script: /* * Note that the [BYTE/INT/FLOAT]ArrayCache

Re: [OpenJDK 2D-Dev] RFR: JDK-8163102: Fix headless only configuration option

Erik: The current --disable-headful option is weird. Even worse, it doesn't work since the makefiles still uses the legacy BUILD_HEADLESS_ONLY variable, which configure never touches. In this patch I'm replacing the configure option with --enable-headless-only. Default is disabled, where

[OpenJDK 2D-Dev] RFR: JDK-8163102: Fix headless only configuration option

Hello, The current --disable-headful option is weird. Even worse, it doesn't work since the makefiles still uses the legacy BUILD_HEADLESS_ONLY variable, which configure never touches. In this patch I'm replacing the configure option with --enable-headless-only. Default is disabled, where

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160456 : KSS : resource loading issue in TIFFMetadataFormat.java

+1 -phil On 8/3/16, 7:38 AM, Brian Burkhalter wrote: Hi Jay, This looks good to me. Thanks, Brian On Aug 3, 2016, at 5:00 AM, Jayathirth D V > wrote: Hi, Please review the following fix in JDK 9 at your convenience: Bug

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160456 : KSS : resource loading issue in TIFFMetadataFormat.java

Hi Jay, This looks good to me. Thanks, Brian On Aug 3, 2016, at 5:00 AM, Jayathirth D V wrote: > Hi, > > Please review the following fix in JDK 9 at your convenience: > > Bug : https://bugs.openjdk.java.net/browse/JDK-8160456 > Webrev

[OpenJDK 2D-Dev] [9] RFR JDK-8160456 : KSS : resource loading issue in TIFFMetadataFormat.java

Hi, Please review the following fix in JDK 9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8160456 Webrev : http://cr.openjdk.java.net/~jdv/8160456/webrev.00/ This is a KSS tool issue. We are not loading resource bundle from specific module in

Re: [OpenJDK 2D-Dev] [9] RFR JDK-5080098: Page Range must be disabled on the common print dlg for Non serv-formatted flvrs

On 8/3/2016 3:15 PM, Jayathirth D V wrote: Hi Prasanta, I tested your changes in linux and windows and it is effecting both the platforms(Page range is disabled). Please clarify whether your changes are specific to linux or it is generic. If it is generic please remove jtreg tag

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

Jim & Phil, I added the following class header in Byte/Int/Float ArrayCache classes and removed the shell script: /* * Note that the [BYTE/INT/FLOAT]ArrayCache files are nearly identical except * for a few type and name differences. Typically, the [BYTE]ArrayCache.java file * is edited

Re: [OpenJDK 2D-Dev] [9] RFR JDK-5080098: Page Range must be disabled on the common print dlg for Non serv-formatted flvrs

Hi Prasanta,   I tested your changes in linux and windows and it is effecting both the platforms(Page range is disabled). Please clarify whether your changes are specific to linux or it is generic. If it is generic please remove jtreg tag @requires (os.family == "linux") else please verify

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6575247: Banner checkbox in PrinterJob print dialog doesn't work

Hi Prasanta, Changes are working fine. Please add @Override annotation for methods in test case and increase sleep time little bit more for test case before pushing. No need for one more review. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Monday, August 01, 2016 2:37