Re: [OpenJDK 2D-Dev] RFR: 8163238: Upgrade to harfbuzz 1.3.0 in JDK 9

2016-08-08 Thread Philip Race
Yes. I saw that (I reviewed the list of fixes that were made after the 1.3.0 release) but JDK9 won't be supporting 10.9 so I figured it was not critical. But also the function that is fixed is not used in our current code. We do use hb_coretext_face_create but that is implemented differently. S

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

2016-08-08 Thread Jim Graham
Does MultiResolutionCachedImage.map() work if the Image hasn't been loaded yet (where getWidth/Height(Observer) can return -1)? Can it ever be called in a case like that? ...jim On 08/08/2016 12:48 PM, Alexander Scherbatiy wrote: Just a friendly reminder. Thanks, Alexandr.

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

2016-08-08 Thread Phil Race
Looks good to me .. +1 -phil. On 08/08/2016 12:48 PM, Alexander Scherbatiy wrote: Just a friendly reminder. Thanks, Alexandr. On 27/06/16 22:17, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8151303/webrev.02 The fix do

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

2016-08-08 Thread Alexander Scherbatiy
Just a friendly reminder. Thanks, Alexandr. On 27/06/16 22:17, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8151303/webrev.02 The fix does not use a new public API to apply filters to multi-resolution images. Thanks,

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8161264: RasterPrinterJob.updateAttributesWithPageFormat does redundant check

2016-08-08 Thread Prasanta Sadhukhan
Gentle Reminder to review.. Regards Prasanta On 7/20/2016 9:48 PM, Prasanta Sadhukhan wrote: No, rest of it is needed as if iw/ih is -ve, then if we do not have this lines if (iw <= 0) iw = (float)(page.getPaper().getWidth()/DPI) - (ix*2); if (ih <= 0) ih = (float)(page.getPaper().getHeight()/D

Re: [OpenJDK 2D-Dev] RFR: 8163238: Upgrade to harfbuzz 1.3.0 in JDK 9

2016-08-08 Thread Sergey Bylokhov
Looks fine. FYI: after release 1.3 there is a fix for coretext crash on osx < 10.10: https://cgit.freedesktop.org/harfbuzz/commit/?id=489acf6c3180d3726158864fa0e1adeea3c23fae On 05.08.16 23:33, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8163238 webrev: http://cr.openjdk.ja