Re: [OpenJDK 2D-Dev] [9] Review Request 8155753: Removing a monitor in the OS dispaly configuration causes assertion fails under Windows

2016-09-13 Thread Vadim Pakhnushev
On 12/09/16 23:06, Semyon Sadetsky wrote: On 9/12/2016 10:36 PM, Vadim Pakhnushev wrote: Looks good to me (have you submitted JPRT job just in case?) Is JPRT really necessary? The native part is only changed for Windows on which the build is deterministic. As you wish --Semyon Vadim On

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate

2016-09-13 Thread Jayathirth D V
Hi Prasanta, Changes are working fine. In both test cases you are not using "private static Label dialogName;". Please remove it. Also some lines are more than 80 characters length and test case has trailing spaces. Please rectify these things before pushing. No need for one more review.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162461: Hang due to JNI up-call made whilst holding JNI critical lock.

2016-09-13 Thread Prasanta Sadhukhan
Looks ok to me. Regards Prasanta On 9/12/2016 9:12 PM, Jayathirth D V wrote: Hi Prasanta, Thanks for your review. There is no need to RELEASE_ARRAYS() for GET_ARRAYS() in line number 578, 588, 994 or 1085. All these calls are coming internally from IJG library and if we have to just make sur