Re: [OpenJDK 2D-Dev] HiDPI support issues on Windows

2016-10-07 Thread Jim Graham
One issue is that the JViewport lastPaintPosition is exposed to subclasses and is an integer location. It is also exposed to all apps via getViewPosition() and getViewRect(). That will conflict with indicating the exact location of the pixel-precise scroll position. It's not clear how these wi

Re: [OpenJDK 2D-Dev] HiDPI support issues on Windows

2016-10-07 Thread Jim Graham
Aren't the components inside the scrollpane located relative to the origin of the entire scrollable region? In which case, the precise location of the visible part of the view has no effect on any component bounds...? ...jim On 10/6/16 5:59 PM, Sergey Bylokhov w

Re: [OpenJDK 2D-Dev] [9] Review Request: 8167310 The graphics clip is incorrectly rounded for some fractional scales

2016-10-07 Thread Jim Graham
That looks great. A couple of questions. Region, line 132: why are you testing for newv > coordinate? Test case: Where do you get white gaps? Is it in the line test? If so, then consider setting the line width higher (or drawing 2 lines per iteration as I mention in the last paragraph). I

[OpenJDK 2D-Dev] [9] Review Request: 8167310 The graphics clip is incorrectly rounded for some fractional scales

2016-10-07 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. This is bug which was found when the fractional scale is used in Swing. The problem is that if we save a usrClip as Rectangle2D then we incorrectly intersect it with device clip. The problem is in the RectangularShape.getBounds() method, see more details

[OpenJDK 2D-Dev] [9] RFR JDK-8167281: IIOMetadataNode bugs in getElementsByTagName and NodeList.item methods

2016-10-07 Thread Jayathirth D V
Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8167281 Webrev : http://cr.openjdk.java.net/~jdv/8167281/webrev.00/ Issue : IIONodeList.item(index) and IIOMetadataNode. getElementsByTagName(tag) are not following spe