Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

2016-10-27 Thread Phil Race
Sorry .. I forgot one thing I meant to mention. Please remove all those commented out frprintf debugging statements. 298 //fprintf(stderr, "gradientInfo->start.x %f, gradientInfo->start.y %f\n", 299 // gradientInfo->start.x, gradientInfo->start.y); 300 //fprintf(stderr, "gradientInfo->end.x %f

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8040635: [macosx] Printing a shape filled with a texture doesn't work under Mac OS X

2016-10-27 Thread Phil Race
+1 -phil. On 10/27/2016 01:07 AM, Prasanta Sadhukhan wrote: Modified webrev after removal of @requires from testcase http://cr.openjdk.java.net/~psadhukhan/8040635/webrev.01/ Regards Prasanta On 10/20/2016 1:40 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for osx printing where

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168609: No link to BMP specification in javax.imageio package documentation

2016-10-27 Thread Phil Race
+1 -phil On 10/27/2016 08:16 AM, Brian Burkhalter wrote: Hi Jay, It looks OK to me. It would be good also to see what Phil or others think. Thanks, Brian On Oct 27, 2016, at 12:08 AM, Jayathirth D V mailto:jayathirth@oracle.com>> wrote: Thanks for your inputs. I have updated the web

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168609: No link to BMP specification in javax.imageio package documentation

2016-10-27 Thread Brian Burkhalter
Hi Jay, It looks OK to me. It would be good also to see what Phil or others think. Thanks, Brian On Oct 27, 2016, at 12:08 AM, Jayathirth D V wrote: > Thanks for your inputs. > I have updated the webrev to include updated hyperlink and copyright year. > Please review it at your convenience: >

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

2016-10-27 Thread Jayathirth D V
Hi Prasanta, Changes are working fine. Thanks, Jay -Original Message- From: Philip Race Sent: Wednesday, October 26, 2016 9:14 PM To: Prasanta Sadhukhan Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on

Re: [OpenJDK 2D-Dev] [PATCH] Make automatic font substitution on macOS work for surrogate pairs

2016-10-27 Thread Dmitry Batrak
Sure, here's the simplest test, that can be used for visual inspection: import javax.swing.*; import java.awt.*; public class SurrogatesFallbackTest { public static void main(String[] args) { SwingUtilities.invokeLater(() -> { JFrame frame = new JFrame(); JLabe

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8040635: [macosx] Printing a shape filled with a texture doesn't work under Mac OS X

2016-10-27 Thread Prasanta Sadhukhan
Modified webrev after removal of @requires from testcase http://cr.openjdk.java.net/~psadhukhan/8040635/webrev.01/ Regards Prasanta On 10/20/2016 1:40 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for osx printing where it is seen that TexturePaint pattern is not getting printed.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168609: No link to BMP specification in javax.imageio package documentation

2016-10-27 Thread Jayathirth D V
Hi Brian, Thanks for your inputs. I have updated the webrev to include updated hyperlink and copyright year. Please review it at your convenience: Webrev : http://cr.openjdk.java.net/~jdv/8168609/webrev.01/ Javadoc with change : http://cr.openjdk.java.net/~jd