Re: [OpenJDK 2D-Dev] [9] Review Request: 8167310 The graphics clip is incorrectly rounded for some fractional scales

2016-10-28 Thread Jim Graham
I suppose that there could be a 4th bug about the fact that the trimming/refining code in the native TransformHelper is based on an inverse transform and subject to bit error, but it's not easy to figure out how to refine it further. Note that it could also cause us to omit a row of pixels in so

Re: [OpenJDK 2D-Dev] [9] Review Request: 8167310 The graphics clip is incorrectly rounded for some fractional scales

2016-10-28 Thread Jim Graham
Hi Alexandr, That code is coming up with maximum extents for the operation, not the exact edges that will be rendered. It passes them down to the native TransformHelper method which refines them using the exact calculations it will use to render the pixels. Admittedly, the calculations you p

Re: [OpenJDK 2D-Dev] [9] Review Request: 8167310 The graphics clip is incorrectly rounded for some fractional scales

2016-10-28 Thread Alexandr Scherbatiy
On 10/11/2016 10:13 PM, Sergey Bylokhov wrote: On 11.10.16 21:54, Jim Graham wrote: Additionally, for AA rendering, there is no such thing as "setClip(someShape)" and "fill(sameShape)" being identical no matter how much we predict which rules they may want because clips are inherently non-AA and

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8165212 VolatileImage should not be compatible with GraphicsConfiguration which transform is changed

2016-10-28 Thread Alexandr Scherbatiy
350 if (!isAccelerationEnabled()) { 351 // Ideally there is no need to re-create a software surface. But 352 // some OSs allow changes to display state at runtime. Such a 353 // provision would cause mismatch in graphics configuration of the 354