Re: [OpenJDK 2D-Dev] [9] RFR JDK-8164750: TIFF reading fails when ignoring metadata with BaselineTIFFTagSet removed

2016-11-01 Thread Phil Race
Hi, I had to do a bit of back-tracing of the source to confirm that ignoreUnknownFields is initialised from the value of ignoreMetadata. +1 -phil. On 10/26/2016 01:05 PM, Brian Burkhalter wrote: Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8164750 Patch

[OpenJDK 2D-Dev] ] [9] Review Request: 8156723: JVM crash at sun.java2d.windows.GDIBlitLoops.nativeBlit

2016-11-01 Thread Mikhail Cherkasov
Hi all, Please review the fix: http://cr.openjdk.java.net/~mcherkas/8156723/webrev/ for https://bugs.openjdk.java.net/browse/JDK-8156723 . To reproduce the issue there relatively complicate steps: 1. connect external monitor to laptop, set laptop screen as the main screen 2. open SwingSet2 3. set

Re: [OpenJDK 2D-Dev] [9] Review Request: 8167310 The graphics clip is incorrectly rounded for some fractional scales

2016-11-01 Thread Sergey Bylokhov
But probably it is possible to tweak the transform? I mean that we can apply the "round", then calculate the diff between resulted destination and destination based on transform, and shift/rescale the transform so it will map exactly the pixels from source edges to destination edges. On 29.10.

Re: [OpenJDK 2D-Dev] [PATCH] Make automatic font substitution on macOS work for surrogate pairs

2016-11-01 Thread Sergey Bylokhov
Looks fine to me, but the jtreg test will be helpful. On 27.10.16 11:56, Dmitry Batrak wrote: Sure, here's the simplest test, that can be used for visual inspection: import javax.swing.*; import java.awt.*; public class SurrogatesFallbackTest { public static void main(String[] args) {