Re: [OpenJDK 2D-Dev] [9] Review Request: [JDK-8166003]: [PIT][TEST_BUG] missing helper for bug6427244.java

2016-11-07 Thread Prasanta Sadhukhan
I guess you can do away with building JRobot too and just use awt Robot via robot.keyPress, robot.mousePress. Do we then need @library ../../../regtesthelpers Additionally, please add 8166003to the bug tag. Regards Prasanta On 11/8/2016 7:50 AM, Prahalad Kumar Narayanan wrote: Hello Everyone

[OpenJDK 2D-Dev] [9] Review Request: [JDK-8166003]: [PIT][TEST_BUG] missing helper for bug6427244.java

2016-11-07 Thread Prahalad Kumar Narayanan
Hello Everyone on Java2D Group Request your time in reviewing the fix for the bug- JDK-8166003 Link: https://bugs.openjdk.java.net/browse/JDK-8166003 Title: [PIT][TEST_BUG] missing helper for javax/swing/text/GlyphPainter2/6427244/bug6427244.java Root Cause: The test case requires

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8165212 VolatileImage should not be compatible with GraphicsConfiguration which transform is changed

2016-11-07 Thread Prahalad Kumar Narayanan
Hello Everyone on Java2D Group This is a follow-up on the bug fix for JDK-8165212. Link: https://bugs.openjdk.java.net/browse/JDK-8165212 Title: VolatileImage should not be compatible with GraphicsConfiguration which transform is changed First, Thanks to Alexandr for his review sugge

Re: [OpenJDK 2D-Dev] [9] RFR 8160888: [PIT] What to expect of updated java/awt/print/PrinterJob/Margins.java

2016-11-07 Thread Philip Race
+1 although ... * ie ix=72 iy=72 iw=451 ih=697 and paper wid=595 that's an "eg" not an "ie" -phil. On 11/7/16, 2:28 AM, Prasanta Sadhukhan wrote: Please find the modified webrev taking care of the suggested changes http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.02/ Regards Prasanta

[OpenJDK 2D-Dev] RFR: 8088325 & 8169339 : Provide internal JDK API to JavaFX to locate JDK fonts

2016-11-07 Thread Phil Race
Hi, Two bug ids, two webrevs and a cross-post since JDK needs to provide a qualified export to JavaFX so it can access any fonts that may be provided with the JDK. FX bug: https://bugs.openjdk.java.net/browse/JDK-8088325 FX fix : http://cr.openjdk.java.net/~prr/8088325/

Re: [OpenJDK 2D-Dev] RFR: 8155874: Fix java.desktop deprecation warnings about Class.newInstance

2016-11-07 Thread Sergey Bylokhov
Looks fine. On 07.11.16 21:49, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8155874 Webrev: http://cr.openjdk.java.net/~prr/8155874/ This hits all across the desktop module, hence the cross-post. The Class.newInstance() has been deprecated since it may throw checked exception

[OpenJDK 2D-Dev] RFR: 8155874: Fix java.desktop deprecation warnings about Class.newInstance

2016-11-07 Thread Phil Race
bug: https://bugs.openjdk.java.net/browse/JDK-8155874 Webrev: http://cr.openjdk.java.net/~prr/8155874/ This hits all across the desktop module, hence the cross-post. The Class.newInstance() has been deprecated since it may throw checked exceptions that are not declared. Class.getConstructor().n

Re: [OpenJDK 2D-Dev] RFR: 8169202: [macos] Font substitution does not work for supplementary characters

2016-11-07 Thread Sergey Bylokhov
Looks fine. On 07.11.16 17:52, Dmitry Batrak wrote: Hello, I'd like to propose a patch for https://bugs.openjdk.java.net/browse/JDK-8169202. I have a Contributor status via agreement signed by JetBrains, hope someone can sponsor the patch. This repeats the proposal I've sent earlier to this mai

[OpenJDK 2D-Dev] RFR: 8169202: [macos] Font substitution does not work for supplementary characters

2016-11-07 Thread Dmitry Batrak
Hello, I'd like to propose a patch for https://bugs.openjdk.java.net/browse/JDK-8169202. I have a Contributor status via agreement signed by JetBrains, hope someone can sponsor the patch. This repeats the proposal I've sent earlier to this mailing list, adding now a reference to the created OpenJD

Re: [OpenJDK 2D-Dev] ] [9] Review Request: 8156723: JVM crash at sun.java2d.windows.GDIBlitLoops.nativeBlit

2016-11-07 Thread Sergey Bylokhov
Looks fine. On 01.11.16 19:45, Mikhail Cherkasov wrote: Hi all, Please review the fix: http://cr.openjdk.java.net/~mcherkas/8156723/webrev/ for https://bugs.openjdk.java.net/browse/JDK-8156723 . To reproduce the issue there relatively complicate steps: 1. connect external monitor to laptop, set

Re: [OpenJDK 2D-Dev] [9] RFR 8160888: [PIT] What to expect of updated java/awt/print/PrinterJob/Margins.java

2016-11-07 Thread Prasanta Sadhukhan
Please find the modified webrev taking care of the suggested changes http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.02/ Regards Prasanta On 11/5/2016 12:13 AM, Phil Race wrote: 80 aset.add(MediaSizeName.ISO_A4); Why ? You can't require that as not everyone has A4 paper handy. @requires