Re: [OpenJDK 2D-Dev] [9] RFR JDK-6334602 : Animated GIFs created from opaque PNG image frames appear transparent when loaded with Toolkit APIs

2016-11-10 Thread Jayathirth D V
Hi Sergey, All the remaining files have "664" chmod permission. I have applied the same on these files. Please find updated webrev for review : http://cr.openjdk.java.net/~jdv/6334602/webrev.01/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, November 08, 2016 5:59

Re: [OpenJDK 2D-Dev] RFR: 8169202: [macos] Font substitution does not work for supplementary characters

2016-11-10 Thread Philip Race
Uint .. but it looks like UniChar is also unsigned. That header file looks like it *is* the documentation. Fine if you already know where to look but .. Anyway based on the report that you've used this for months in production I can give this a "+1" Sergey already reviewed too. Who is going to

Re: [OpenJDK 2D-Dev] RFR: 8169202: [macos] Font substitution does not work for supplementary characters

2016-11-10 Thread Dmitry Batrak
Updated webrev (removed wild card import): http://cr.openjdk.java.net/~avu/JDK-8169202/webrev.03/ As for UnicodeScalarValue, I couldn't find its description (or the description of an equivalent type UTF32Char) on developer.apple.com either. It's defined at MacTypes.h, at the same place where UniCh

Re: [OpenJDK 2D-Dev] [9] RFR 4987884: PrinterJob carries over some values between calls to print.

2016-11-10 Thread Prasanta Sadhukhan
Modified webrev to ensure attributes set are cleared before return so that subsequent print() call start off with clean-slate. http://cr.openjdk.java.net/~psadhukhan/4987884/webrev.03/ One thing is, due to this contract for print(PrintRequestAttributes) which specifies /"some attributes may be

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8165212 VolatileImage should not be compatible with GraphicsConfiguration which transform is changed

2016-11-10 Thread Sergey Bylokhov
Looks fine. On 10.11.16 0:07, Phil Race wrote: +1 -phil. On 11/07/2016 06:17 PM, Prahalad Kumar Narayanan wrote: Hello Everyone on Java2D Group This is a follow-up on the bug fix for JDK-8165212. Link: https://bugs.openjdk.java.net/browse/JDK-8165212 Title: VolatileImage should