Re: [OpenJDK 2D-Dev] PostScript PrintJob LANDSCAPE computes wrong value for getStringBounds

2016-12-20 Thread Phil Race
There is also https://bugs.openjdk.java.net/browse/JDK-8139178 The problem there sounds like mixing up horizontal and vertical under rotation. But yours (if I read you correctly) is more that the advances are off by a little. I think 8159061

Re: [OpenJDK 2D-Dev] [9] RFR 8170579: The "Banner page" checkbox is disabled

2016-12-20 Thread Phil Race
+1 to the changes although did you manage to confirm if it is specific to a particular printer ? I recommend installing 16.10 in a virtual box and taking a look at the cups server (localhost:631) as well as the System Settings->Printers dialog. On 16.04 these so prominently let me specify job sh

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8170578: The Pages Range From in print dialog is disabled

2016-12-20 Thread Prahalad Kumar Narayanan
Note: Sending feedback again with right subject line. The changes check whether the platform supports PageRanges before starting the test-case. Looks good. Thanks & Have a good day Prahalad N. Date: Mon, 19 Dec 2016 15:22:55 +0300 From: Prasanta Sadhukhan To: Jayathirth D V , Philip Race

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8170578: The Pages Range From in print

2016-12-20 Thread Prahalad Kumar Narayanan
The changes check whether the platform supports PageRanges before starting the test-case. Looks good. Thanks & Have a good day Prahalad N. Date: Mon, 19 Dec 2016 15:22:55 +0300 From: Prasanta Sadhukhan To: Jayathirth D V , Philip Race , 2d-dev <2d-dev@openjdk.java.net> Subject: Re: [O

Re: [OpenJDK 2D-Dev] RFR: 8166111: [PIT] possible regression: java/awt/font/GlyphVector/TestLayoutFlags.java

2016-12-20 Thread Sergey Bylokhov
Looks fine. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8166111 > Webrev: http://cr.openjdk.java.net/~prr/8166111/ > > Test fix. Details in the bug evaluation but in short, > the test assumes a 1:1 mapping of chars:glyphs by layout. > > -phil.

Re: [OpenJDK 2D-Dev] RFR: 8130737: AffineTransformOp can't handle child raster with non-zero x-offset

2016-12-20 Thread Sergey Bylokhov
Looks fine. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8130737 > Webrev : http://cr.openjdk.java.net/~prr/8130737/ > > If a child raster is created with a non-zero x-offset then subsequently > in the code that validates the raster for imaging operations we may > incorrectly calculate tha

[OpenJDK 2D-Dev] Missing floating-point-precision method in font measuring API

2016-12-20 Thread Dmitry Batrak
Missing floating-point-precision method in font measuring API Hello, It looks like there's currently a gap in text measuring API with respect to methods working with floating point coordinates. It's not something new, but with HiDPI support added in Java 9, it seems to become more significant. C

Re: [OpenJDK 2D-Dev] RFR: 8130737: AffineTransformOp can't handle child raster with non-zero x-offset

2016-12-20 Thread Jim Graham
+1 for the code changes, but I didn't review the test case... ...jim On 12/19/16 8:48 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8130737 Webrev : http://cr.openjdk.java.net/~prr/8130737/ If a child raster is created with a non-zero x-offset th

Re: [OpenJDK 2D-Dev] RFR(S): 8171248: Minor HarfBuzz fixes to pacify Coverity code scan

2016-12-20 Thread Volker Simonis
On Mon, Dec 19, 2016 at 10:05 PM, Phil Race wrote: > I have created a bug on the upgrade > https://bugs.openjdk.java.net/browse/JDK-8171456 > > I don't expect to get to this until January as I'll be out until then and > there is > some internal process to be navigated. And of course Behdad needs t