Re: [OpenJDK 2D-Dev] [9] RFR JDK-8173064: Unexpected tag in javax/imageio/plugins/tiff/package.html

2017-01-19 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 1/20/2017 12:33 PM, Jayathirth D V wrote: Hello All, Please review the following fix in JDK9 : Bug : https://bugs.openjdk.java.net/browse/JDK-8173064 Webrev : http://cr.openjdk.java.net/~jdv/8173064/webrev.00/

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8173064: Unexpected tag in javax/imageio/plugins/tiff/package.html

2017-01-19 Thread Ambarish Rapte
Hi Jay, The change looks good to me. Regards, Ambarish From: Jayathirth D V Sent: Friday, January 20, 2017 12:33 PM To: 2d-dev@openjdk.java.net Subject: [OpenJDK 2D-Dev] [9] RFR JDK-8173064: Unexpected tag in javax/imageio/plugins/tiff/package.html Hello All, Please review the

[OpenJDK 2D-Dev] [9] RFR JDK-8173064: Unexpected tag in javax/imageio/plugins/tiff/package.html

2017-01-19 Thread Jayathirth D V
Hello All, Please review the following fix in JDK9 : Bug : https://bugs.openjdk.java.net/browse/JDK-8173064 Webrev : http://cr.openjdk.java.net/~jdv/8173064/webrev.00/ Html : http://cr.openjdk.java.net/~jdv/8173064/package.html Issue : There was extra tag present in package.html

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

2017-01-19 Thread dmitry markov
Hi Prasanta, Thank you for your feedback. Actually there are two problems here: JDK-8163889 is devoted to the crash/assert error and JDK-8173050 which is about possible lack of support for

Re: [OpenJDK 2D-Dev] RFR: 8172999: Crash on Windows getting FontMetrics since JDK 9 b96

2017-01-19 Thread Vadim Pakhnushev
Looks good. On 19.01.2017 2:08, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8172999 Webrev: http://cr.openjdk.java.net/~prr/8172999/ fix for a crash on windows. -phil.

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

2017-01-19 Thread Jayathirth D V
Hello All, After getting feedback from Joe in CCC I have made changes to the code to reflect Joe's suggestions. For ColorModel class I have just added identity-is-equality equals(). For its subclasses like IndexColorModel, PackedColorModel & ComponentColorModel, I have added instanceOf checks