Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2017-03-30 Thread Jim Graham
That sounds useful, but is your example code complete? Don't you need to declare the "image" variable with the appropriate generic type? Also, do we get a lot of compiler warnings if you want to ignore the generics in other code? What's the pain point if you don't care what the types of the i

Re: [OpenJDK 2D-Dev] [9] Review request for 8167102: [macosx] PrintRequestAttributeSet breaks page size set using PageFormat

2017-03-30 Thread Phil Race
Hi, OK I accept your assurances regarding testing and the observed behaviours, so "+1" to the fix. If you plan to push this to jdk 9 please follow the RDP2 process and add the required "Fix comment" and jdk9-fix-request label. -phil. On 03/30/2017 11:32 AM, Anton Litvinov wrote: Hello Phil,

Re: [OpenJDK 2D-Dev] [9] Review request for 8167102: [macosx] PrintRequestAttributeSet breaks page size set using PageFormat

2017-03-30 Thread Anton Litvinov
Hello Phil, Thank you very much for review of this fix. The new or the 3rd version of the fix, in which I tried to address your remarks, is created and is available at the next URL. The changes introduced into the fix are summarized in the end of the e-mail. Could you please review the new ve