Re: [OpenJDK 2D-Dev] [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

2017-05-05 Thread Jonathan Gibbons
Sergey, This is not a comment on the content of the review; it is a minor comment on your interpretation of . is a block-level tag that is implicitly terminated by any of many block-level tags. For the full list, see the W3C definition of the p element in HTML 5: https://www.w3.org/TR/html

Re: [OpenJDK 2D-Dev] [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

2017-05-05 Thread Alex Menkov
Okay, Then +1 to Phil's approval --alex On 05/05/2017 12:37, Sergey Bylokhov wrote: Hi, Alexey. Yes it is possible to add to this changes, but actually tag is not used in JavaSound docs. The last one were removed a few years ago. The tag is used in assumption that it affect the text till

Re: [OpenJDK 2D-Dev] CFV: New2d group member : Laurent Bourges

2017-05-05 Thread Jim Graham
Vote: yes ...jim On 5/5/17 12:54 PM, Phil Race wrote: I hereby nominate Laurent Bourges to membership in the 2D group.

Re: [OpenJDK 2D-Dev] [10] Marlin2D upgrade 0.7.5

2017-05-05 Thread Jim Graham
Hi Laurent, A couple of comments that might just be points for clarification. Minimally it would make sense to include the JBS report number on the third item below, but the rest are just notes and suggestions... On 4/26/17 2:32 PM, Laurent Bourgès wrote: - MarlinProperties - TileSize vs

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2017-05-05 Thread Sergey Bylokhov
Hi, Jim, Phil. > That sounds useful, but is your example code complete? Don't you need > to declare the "image" variable with the > appropriate generic type? I guess its s too late to change it right now? Now I thinking of possibility to change the Robot API to simplify its usage in the tests.

Re: [OpenJDK 2D-Dev] [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

2017-05-05 Thread Phil Race
This all looks OK to me. -phil. On 05/04/2017 06:15 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9-dev. This fix is a part of the effort to make all javadoc in jdk9 be compatible to HTML5. In the fix the most common issues are fixed. The issues related to tables will be fixe

Re: [OpenJDK 2D-Dev] CFV: New2d group member : Laurent Bourges

2017-05-05 Thread Phil Race
Vote: yes -phil.

Re: [OpenJDK 2D-Dev] CFV: New2d group member : Laurent Bourges

2017-05-05 Thread Sergey Bylokhov
Vote: yes - philip.r...@oracle.com wrote: > I hereby nominate Laurent Bourges to membership in the 2D group. > > Laurent is the principal (almost sole) author of the Marlin Renderer > contributed > into OpenJDK via the Graphics Rasterizer project [1] and integrated into JDK > 9 > via

[OpenJDK 2D-Dev] CFV: New2d group member : Laurent Bourges

2017-05-05 Thread Phil Race
I hereby nominate Laurent Bourges to membership in the 2D group. Laurent is the principal (almost sole) author of the Marlin Renderer contributed into OpenJDK via the Graphics Rasterizer project [1] and integrated into JDK 9 via JEP 265 [2]. In addition to that single extremely significant and

Re: [OpenJDK 2D-Dev] [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

2017-05-05 Thread Sergey Bylokhov
Hi, Alexey. Yes it is possible to add to this changes, but actually tag is not used in JavaSound docs. The last one were removed a few years ago. The tag is used in assumption that it affect the text till the next or till the end of the doc. So for example in the MidiMessage.java/SizeSequenc

Re: [OpenJDK 2D-Dev] [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

2017-05-05 Thread Alex Menkov
Overall looks good. One minor point - there are several places when you replace with without end . Usually absent doesn't cause any problem, but it would be better to have end tags for all elements. I see this in src/java.desktop/share/classes/javax/sound/midi/MidiMessage.java src/java.desk