Hello Brian
Thank you for your time in review.
It's a valid suggestion to include a "round trip" test case where we write a
PNG file with "Creation Time" in text chunk and verify the same with a read
operation.
This use case has been added to the existing test case and it passes with the
fix.
Hello Phil
You are correct. I missed to take note of calloc() at Line 347.
The changes are good.
Thank you
Have a good day
Prahalad N.
-Original Message-
From: Phil Race
Sent: Monday, August 28, 2017 11:34 PM
To: Prahalad Kumar Narayanan; srl
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] RF
Hi Laurent,
On 8/28/17 2:09 PM, Laurent Bourgès wrote:
Hi Jim,
Thanks for your comments, it helped refining the webrev.
Here are my answers:
2017-08-26 2:22 GMT+02:00 Jim Graham mailto:james.gra...@oracle.com>>:
[D]Dasher.java - why the changes from (firstSegIdx > 0) to (firstSegIdx !=
Hello Prahalad,
I think this looks OK. I wonder however whether it might not hurt to add a
“round trip” sub-test which would write out the image containing the
CreationTime and then read it back in and verify that the time was actually
written to the image. I think this is optional so if you wa
Hi Jim,
Thanks for your comments, it helped refining the webrev.
Here are my answers:
2017-08-26 2:22 GMT+02:00 Jim Graham :
> [D]Dasher.java - why the changes from (firstSegIdx > 0) to (firstSegIdx !=
> 0)?
>
As firstSegIdx is initialized to 0, I prefer testing (firstSegIdx != 0) as
it looks
You elided an important line here :
347 TTLayoutTableCache* ltc = calloc(1, sizeof(TTLayoutTableCache));
The memory is allocated using calloc so is zeroed on allocation.
-phil.
On 08/26/2017 12:06 PM, Prahalad Kumar Narayanan wrote:
Hello Phil
The change looks good to me.
Thank you for t
