Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

2017-10-23 Thread Phil Race
Yes, that would work .. ie preserve the status quo .. not needed in 10 though, this would be 8-only. Are you going to push the 10 version of the fix any time soon ? -phil. On 10/19/2017 01:59 AM, Mario Torre wrote: On Thu, Sep 28, 2017 at 6:23 PM, Philip Race wrote: I think for JDK 8 you c

[OpenJDK 2D-Dev] RFR: 8180501: RescaleOp.filter does not document IllegalArgumentException if sizes differ.

2017-10-23 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8180501 Webrev: http://cr.openjdk.java.net/~prr/8180501/ RescaleOp has never documented that it throws IAE for different sized images, even though it always has done so .. A CSR has been filed for this. https://bugs.openjdk.java.net/browse/JDK-818

Re: [OpenJDK 2D-Dev] RFR: 8180501: RescaleOp.filter does not document IllegalArgumentException if sizes differ.

2017-10-23 Thread Brian Burkhalter
On Oct 23, 2017, at 12:56 PM, Phil Race wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8180501 > Webrev: http://cr.openjdk.java.net/~prr/8180501/ > > RescaleOp has never documented that it throws IAE for different sized images, > even though it always has done so .. Looks fine. > A CSR

Re: [OpenJDK 2D-Dev] RFR: 8180501: RescaleOp.filter does not document IllegalArgumentException if sizes differ.

2017-10-23 Thread Phil Race
Fixed .. the tool looks like "None" is acceptable but won't, in fact, accept it. I've changed it to minimal. -phil. On 10/23/2017 01:02 PM, Brian Burkhalter wrote: A CSR has been filed for this. https://bugs.openjdk.java.net/browse/JDK-8189826 Please review that also. I cannot add mysel

Re: [OpenJDK 2D-Dev] RFR: 8180501: RescaleOp.filter does not document IllegalArgumentException if sizes differ.

2017-10-23 Thread Brian Burkhalter
Indeed I found that out myself in one I submitted recently. Reviewed. Brian On Oct 23, 2017, at 1:18 PM, Phil Race wrote: > Fixed .. the tool looks like "None" is acceptable but won't, in fact, accept > it. > > I've changed it to minimal.

[OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

2017-10-23 Thread Sergey Bylokhov
Hello, Please review the fix for. 8182410: missing 'title' in api/javax/swing/plaf/synth/doc-files/componentProperties.html 8183508: multi_tsc.html should be updated 8181289: Invalid HTML 5 in AWT/Swing docs Description: - Illegal characters were removed. - Unsupported tags/properties were r

Re: [OpenJDK 2D-Dev] RFR: 8180501: RescaleOp.filter does not document IllegalArgumentException if sizes differ.

2017-10-23 Thread Prahalad Kumar Narayanan
Hello Phil The changes look good. Thank you Have a good day Prahalad N. -Original Message- From: Phil Race Sent: Tuesday, October 24, 2017 1:26 AM To: 2d-dev Subject: [OpenJDK 2D-Dev] RFR: 8180501: RescaleOp.filter does not document IllegalArgumentException if sizes differ. Bug: http

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

2017-10-23 Thread Semyon Sadetsky
Hi Sergey, I see no reason to have an extra empty anchor tag to set a bookmark. The id attribute works with any element. For example:         Definitions should be     Definitions --Semyon On 10/23/2017 02:42 PM, Sergey Bylokhov wrote: Hello, Please review the fix for. 8182410: missing

Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

2017-10-23 Thread Mario Torre
On Mon, Oct 23, 2017 at 9:28 PM, Phil Race wrote: > Yes, that would work .. ie preserve the status quo .. not needed in 10 > though, this would be 8-only. > > Are you going to push the 10 version of the fix any time soon ? I would like to push it today, however I'm not sure if I still need a seco