Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-11-14 Thread Phil Race
Based on timeout failures I've seen for tests that do not specify a timeout, the default timeout (currently) is 2 minutes. @ignore will by default make jtreg report the test as having an ERROR .. not failed ! The logic for this behaviour is a bit odd but it is what it is/ To have jtreg really i

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-11-14 Thread Sergey Bylokhov
Hi, Laurent. On 14/11/2017 14:03, Laurent Bourgès wrote: PS: I added the new ClipShapeTests with special jtreg tags: what is the default timeout ? The complete tests are slow ~ 20mins, so I added @ignore but it marks the test as failed. Why not split it across the threads? 5~7 minutes is not a

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-11-14 Thread Laurent Bourgès
Phil, Here is the new webrev against up-to-date jdk forrest (2D) + tested with jtreg (marlin package) that provides latest Marlin 0.8.2 including the new path clipping filter (Stroker & Filler): http://cr.openjdk.java.net/~lbourges/marlin/marlin-082-8184429.0/ I will create a new bug (as the curr

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

2017-11-14 Thread Jonathan Gibbons
Semyon, I read the HTML 5 spec the same as you, and we (on the Javadoc team) started using id on other elements, as well as to provide a target that could be linked to. However, the pragmatic experience was that the scrolling in some browsers did not completely reveal the element when there

Re: [OpenJDK 2D-Dev] [10] Review Request: JDK-8159142 : Visible artifacts in sun/java2d/SunGraphics2D/DrawImageBilinear.java

2017-11-14 Thread Pankaj Bansal
Hi Prahalad, Thanks for the review. Yes, the test fails at 1.75 scale value both before and after the fix on GDI, OpenGL and D3D pipelines with exceptions similar to this. Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Test failed at x=10 y=10 (expected=0x000

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException/OOM error when IHDR width is very large

2017-11-14 Thread Jayathirth D V
Hi, Thanks for the review Phil and Prahalad. Based on the suggestions I have updated the code to wrap underlying Exception/Error in IIOException instead of overriding the message content and removed the check for IndexOutOfBoundsException. Corresponding test case changes are also done.

Re: [OpenJDK 2D-Dev] [10] Review Request: JDK-8159142 : Visible artifacts in sun/java2d/SunGraphics2D/DrawImageBilinear.java

2017-11-14 Thread Prahalad Kumar Narayanan
Hello Pankaj Good day to you. I imported your changes and checked the build with the JTreg test file. . I tried random uiScales using -Dsun.java2d.uiScale and by adjusting DPI scale on Windows 10. . The test failed at uiScale set at 1.75 on all the pipelines- D3D, OpenGL and GDI.