Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

2018-03-16 Thread Alex Menkov
On 03/15/2018 13:09, Magnus Ihse Bursie wrote: 15 mars 2018 kl. 20:13 skrev Phil Race : As far as I know the split was made to dynamically load ALSA/DirectSound stuff Yes, I think it is something like that for Linux ie if at runtime a dependent-but-not-essential .so was not installed it

Re: [OpenJDK 2D-Dev] [11] Review Request: 4912693 Behavior of null arguments not specified in Java Sound

2018-03-16 Thread Phil Race
- * are examples of typical and acceptable run time exceptions for such cases. + * are the examples of typical and acceptable run time exceptions for such + * cases. all changes like this make the grammar WRONG. "the examples" means you've enumerated all of them in which case they are no longe

Re: [OpenJDK 2D-Dev] [11] RFR [JDK-6686236] GIF native IIOMetadata assumes characterCellWidth/Height as 2bytes

2018-03-16 Thread Phil Race
Looks fine but get an approved CSR. -phil. On 03/16/2018 05:01 AM, Prahalad Kumar Narayanan wrote: Hello Everyone Good day to you. Request your time in reviewing a simple fix for . Bug : [JDK-6686236] https://bugs.openjdk.java.net/browse/JDK-6686236 . Title : GIF native IIOMetadata

[OpenJDK 2D-Dev] [11] RFR [JDK-6686236] GIF native IIOMetadata assumes characterCellWidth/Height as 2bytes

2018-03-16 Thread Prahalad Kumar Narayanan
Hello Everyone Good day to you. Request your time in reviewing a simple fix for . Bug : [JDK-6686236] https://bugs.openjdk.java.net/browse/JDK-6686236 . Title : GIF native IIOMetadata assumes characterCellWidth/Height as 2bytes Root Cause: . As per the gif image format specification