Re: [OpenJDK 2D-Dev] RFR 8199789: Emit a warning message when t2k is selected via system property

2018-03-20 Thread Prahalad Kumar Narayanan
Hello Phil Good day to you. Thank you for the explanation. I understand your point now. The code changes look good. Thank you Have a good day Prahalad N. - Original Message - From: Phil Race Sent: Wednesday, March 21, 2018 12:14 AM To: Prahalad Kumar Narayanan; 2d-dev Subject: Re:

Re: [OpenJDK 2D-Dev] RFR 8199789: Emit a warning message when t2k is selected via system property

2018-03-20 Thread Phil Race
I typed + (!(FontUtilities.useT2K && !FontUtilities.useLegacy) ? when I actually meant + ((!FontUtilities.useT2K && !FontUtilities.useLegacy) ? ie the first "!" was supposed to be inside .. I decided to add a debugging option to make it easier to tell what you'd got and then further decided

Re: [OpenJDK 2D-Dev] RFR: 8199870: colorimaging.md needs to remove mention of KCMS

2018-03-20 Thread Sergey Bylokhov
+1 On 20/03/2018 09:54, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8199870 Diff: inline below The legal attribution file src/java.desktop/share/legal/colorimaging.md references the Kodak Color Management System which not only was never in OpenJDK, but is not in Oracle JDK

Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

2018-03-20 Thread Phil Race
In that case the patch is fine. -phil. On 03/20/2018 12:15 AM, Jayathirth D V wrote: HI Phil, Please find my observation: In case of DIB header type BITMAPINFOHEADER/ BITMAPV4HEADER/ BITMAPV5HEADER, Microsoft documentation(https://msdn.microsoft.com/en-us/library/dd183376(v=vs.85).aspx

[OpenJDK 2D-Dev] RFR: 8199870: colorimaging.md needs to remove mention of KCMS

2018-03-20 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8199870 Diff: inline below The legal attribution file src/java.desktop/share/legal/colorimaging.md references the Kodak Color Management System which not only was never in OpenJDK, but is not in Oracle JDK anymore either .. This simple patch just

Re: [OpenJDK 2D-Dev] RFR 8199789: Emit a warning message when t2k is selected via system property

2018-03-20 Thread Prahalad Kumar Narayanan
Hello Phil Good day to you. I imported your patch and checked the resulting build. Warnings showed up as expected with use of "t2k" or "legacy" in the VM option -Dsun.java2d.font.scaler. However, I'm unable to interpret this line and its intended outcome. > It also adds a new value for

Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

2018-03-20 Thread Jayathirth D V
HI Phil, Please find my observation: In case of DIB header type BITMAPINFOHEADER/ BITMAPV4HEADER/ BITMAPV5HEADER, Microsoft documentation(https://msdn.microsoft.com/en-us/library/dd183376(v=vs.85).aspx ) mentions that mask values are valid only when compression type is BI_BITFIELDS. When